Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spacing to header elements #42

Merged
merged 5 commits into from
Jul 18, 2024
Merged

Add spacing to header elements #42

merged 5 commits into from
Jul 18, 2024

Conversation

Plebysnacc
Copy link
Contributor

This branch adds responsive spacing to the header elements, especially the links.

Things to consider:

  • There are some weird pixel-widths that make the "homepage" link disappear, I have not yet found a fix for that. Maybe we wanna push that fix to the implementation of the mobile view, as it seems to only bother very small width windows
  • Ignore the commit messages, I fucked up a merge

@Plebysnacc Plebysnacc linked an issue Jul 18, 2024 that may be closed by this pull request
header top right items should not have relative spacing #20
Closed
Xeldlie
Xeldlie approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@Xeldlie Xeldlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

dheidemann
dheidemann approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@dheidemann dheidemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pascht

@Plebysnacc Plebysnacc merged commit cb33d9c into main Jul 18, 2024
2 checks passed
@Plebysnacc Plebysnacc deleted the 20-header-spacing branch July 18, 2024 14:02
@dheidemann
Copy link
Member

walum ita build failing?

@dheidemann
Copy link
Member

doesnt seem to be related to this pr... continuing in #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xeldlie Xeldlie Xeldlie approved these changes

@dheidemann dheidemann dheidemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
pepp
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

header top right items should not have relative spacing
3 participants
@Plebysnacc @dheidemann @Xeldlie