-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gsw instead of seawater #128
base: main
Are you sure you want to change the base?
Conversation
Found a first problem. I think this happens in:
|
I think it's ok to replace ptmp from https://pythonhosted.org/seawater/eos80.html with https://teos-10.github.io/GSW-Python/_modules/gsw/_wrapped_ufuncs.html#pt_from_t. We would update from EOS80 to TEOS10, which I think is good. Need to be sure this does not clash with our obs input file or FESOM2 output units. We also have to give pref=0, which used to be a default with the old function. |
Ich hatte das vorm urlaub auch schon mal ins auge gefasst. Hab dann aber gemerkt das man da vorsichtig sein muss. Da die gsw routinen als input nicht mehr potentielle temperatur haben sondern CT conservative temperature. Wenn mann das glaub ich korrect machen will muss man da noch einen zwischen schritt einbauen mit PT --> CT. Ich wollte das ohnehin nach dem urlaub mit machen. |
Are you sure? There is also CT to T, but this function is specifically called PT to T. Same checks should be done for the lastest commit where I switch from sw.dens to gsw.rho. |
Needs a thorough test. Not to be merged before #127