Main ifs thermo #612
Main ifs thermo #612
Conversation
…is the improved sea ice thermodynamics for coupling with IFS/OpenIFS
dsidoren
requested review from
hegish and
JanStreffing
and removed request for
hegish
| @@ -248,13 +248,13 @@ subroutine ice_timestep(step, ice, partit, mesh) | |||
| #endif | |||
| #endif /* (__oifs) */ | |||
| if (flag_debug .and. mype==0) print *, achar(27)//'[36m'//' --> call ice_TG_rhs_div...'//achar(27)//'[0m' | |||
| call ice_TG_rhs_div (ice, partit, mesh) | |||
| call ice_TG_rhs (ice, partit, mesh) | |||
There was a problem hiding this comment.
this line will lead to the change of the test results
|
|
||
| if (flag_debug .and. mype==0) print *, achar(27)//'[36m'//' --> call ice_fct_solve...'//achar(27)//'[0m' | ||
| call ice_fct_solve (ice, partit, mesh) | ||
|
|
||
| if (flag_debug .and. mype==0) print *, achar(27)//'[36m'//' --> call ice_update_for_div...'//achar(27)//'[0m' | ||
| call ice_update_for_div(ice, partit, mesh) | ||
| ! call ice_update_for_div(ice, partit, mesh) |
There was a problem hiding this comment.
this line will lead to the change of the test results
|
Here is the tripyview evaluation of a 1958 to 2017 standalone core2 run with these changes vs the same period with the current main branch. I have nowhere to host the html, so as a pdf instead: |
|
Patterns look to be similar in magnitude and shape but inverted compared to #86 |
|
Besides the standalone evalulation in the previews comment I also did 50 years AWI-CM3 TCo95L91-CORE2 with constant year 2000 forcing. The results are good; cmpi-tool score is low: I did not output the right MLD (MLD3). Deep ocean salt and temp make no sense to compare after 50 years. |
change in the thermodynamics proposed by Dmitry Sein which is required for more physical coupling with IFS type models. In the sea ice step we also neglect the divergent part since its contribution is negligible and sometimes caused errors on levante. The results might be not reproducible!