-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π§ [WIP] ποΈ Hotfix 1.8.7: Restore longitudinal functionality #2160
Draft
shnizzedy
wants to merge
33
commits into
main
Choose a base branch
from
hotfix-1.8.7/longitudinal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
[skip ci]
[skip ci]
[skip ci]
[skip ci]
shnizzedy
force-pushed
the
hotfix-1.8.7/longitudinal
branch
from
November 1, 2024 14:04
16cebc1
to
87dd957
Compare
shnizzedy
force-pushed
the
hotfix-1.8.7/longitudinal
branch
from
November 1, 2024 18:31
d3a5a8e
to
e7e82b7
Compare
I don't understand why we do this twice: C-PAC/CPAC/longitudinal_pipeline/longitudinal_workflow.py Lines 520 to 535 in e7e82b7
C-PAC/CPAC/longitudinal_pipeline/longitudinal_workflow.py Lines 1178 to 1189 in e7e82b7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2159 by @Shinwon Park
Related to Longitudinal project spec by @e-kenneally
Description
T1w-brain-template
towarp_longitudinal_T1w_to_template
's inputs and updatesC-PAC/CPAC/longitudinal_pipeline/longitudinal_workflow.py
Line 314 in 96db8b0
C-PAC/CPAC/longitudinal_pipeline/longitudinal_workflow.py
Line 316 in 16cebc1
from-longitudinal_to-T1w_mode-image_desc-linear_xfm
on the fly withC-PAC/CPAC/longitudinal_pipeline/longitudinal_workflow.py
Lines 366 to 380 in 16cebc1
C-PAC/CPAC/longitudinal_pipeline/longitudinal_workflow.py
Line 469 in 96db8b0
C-PAC/CPAC/longitudinal_pipeline/longitudinal_workflow.py
Lines 491 to 492 in 16cebc1
test_config
to run without running the graphs.C-PAC/CPAC/longitudinal_pipeline/longitudinal_workflow.py
Lines 475 to 493 in 96db8b0
C-PAC/CPAC/longitudinal_pipeline/longitudinal_workflow.py
Lines 495 to 502 in 16cebc1
C-PAC/CPAC/longitudinal_pipeline/longitudinal_workflow.py
Lines 504 to 644 in 16cebc1
C-PAC/CPAC/longitudinal_pipeline/longitudinal_workflow.py
Line 495 in 96db8b0
C-PAC/CPAC/registration/registration.py
Lines 3515 to 3529 in 96db8b0
C-PAC/CPAC/registration/registration.py
Lines 3570 to 3583 in 96db8b0
C-PAC/CPAC/registration/registration.py
Lines 3516 to 3558 in e7e82b7
C-PAC/CPAC/pipeline/engine.py
Lines 1095 to 1097 in 96db8b0
C-PAC/CPAC/pipeline/engine.py
Lines 1116 to 1121 in 16cb70c
rpool
toC-PAC/CPAC/pipeline/engine.py
Lines 2362 to 2364 in 16cb70c
{}
C-PAC/CPAC/pipeline/engine.py
Line 2403 in 16cb70c
C-PAC/CPAC/registration/registration.py
Lines 2367 to 2374 in 96db8b0
T1w
andlongitudinal
xfms in rpoolC-PAC/CPAC/seg_preproc/seg_preproc.py
Lines 437 to 459 in 96db8b0
C-PAC/CPAC/seg_preproc/seg_preproc.py
Lines 437 to 440 in e7e82b7
Technical details
subject_id
attribute onConfiguration
object in anatomical longitudinal workflowΒ #2158 from 1.8.8 development..github/scripts/autoversioning.sh
update-yaml-comments
job in pre-commit CIβ»οΈ refactor
warp_T1mask_to_template
towarp_mask_to_template
C-PAC/CPAC/registration/registration.py
Lines 3570 to 3623 in 96db8b0
C-PAC/CPAC/registration/registration.py
Lines 3575 to 3633 in e916d33
Tests
Screenshots
Checklist
Update index.md
).main
branch of the repository.Developer Certificate of Origin
Developer Certificate of Origin