-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Netlify Logo #56
Add Netlify Logo #56
Conversation
✅ Deploy Preview for dev-fcccolumbus ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the footer test is failing. please fix
› 2 snapshots failed from 2 test suites. Inspect your code changes or press `u` to update them.
Test Suites: 2 failed, 6 passed, 8 total
Tests: 2 failed, 12 passed, 14 total
Snapshots: 2 failed, 6 passed, 8 total
Time: 4.47 s
Ran all test suites.
Overall, looks good. I'll wait till the failing test is resolved before approving. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The minor formatting issue and failing test have been addressed. Everything looks good on 51453b4
. Approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 passed
TL/DR
This PR updates the footer component by adding the netlify logo.
Overview of Change
Footer.jsx
<a>
&<img/>
tags with netlify link & logo<a>
tagindex.css
<a>
&<img/>
tags