Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Netlify Logo #56

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Conversation

mmcbride2929
Copy link
Collaborator

@mmcbride2929 mmcbride2929 commented Aug 2, 2023

TL/DR

This PR updates the footer component by adding the netlify logo.

Overview of Change

Footer.jsx

  • Add <a> & <img/> tags with netlify link & logo
  • Add className to <a> tag

index.css

  • Style <a> & <img/> tags

netlify-logo

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for dev-fcccolumbus ready!

Name Link
🔨 Latest commit 51453b4
🔍 Latest deploy log https://app.netlify.com/sites/dev-fcccolumbus/deploys/64cad8110f4db4000866985a
😎 Deploy Preview https://deploy-preview-56--dev-fcccolumbus.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmcbride2929 mmcbride2929 changed the title Add Netlify Logo #51 Add Netlify Logo Aug 2, 2023
Copy link
Collaborator

@readysetagile readysetagile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the footer test is failing. please fix

 › 2 snapshots failed from 2 test suites. Inspect your code changes or press `u` to update them.

Test Suites: 2 failed, 6 passed, 8 total
Tests:       2 failed, 12 passed, 14 total
Snapshots:   2 failed, 6 passed, 8 total
Time:        4.47 s
Ran all test suites.

src/index.css Show resolved Hide resolved
@jduffey
Copy link
Collaborator

jduffey commented Aug 2, 2023

Overall, looks good. I'll wait till the failing test is resolved before approving.

Copy link
Collaborator

@jduffey jduffey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minor formatting issue and failing test have been addressed. Everything looks good on 51453b4. Approved. :shipit:

@readysetagile readysetagile linked an issue Aug 3, 2023 that may be closed by this pull request
Copy link
Collaborator

@readysetagile readysetagile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 passed

@readysetagile readysetagile merged commit ec5293a into FCCColumbus:dev Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Netlify logo to home page
3 participants