Fixing problem with inconsistent signal line colours #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re colours defined in plotting configs for signal
DBAnthony
reviewed
Oct 19, 2020
| @@ -140,7 +140,7 @@ def __call__(self, col, **kwargs): | |||
| width = self.linewidth | |||
| style = "-" | |||
| else: | |||
| color = None | |||
| color = color | |||
There was a problem hiding this comment.
Could you do something like color if color else None?
There was a problem hiding this comment.
Yeah, I can try that. Seems like an easy enough change
There was a problem hiding this comment.
Ahh, that doesn't work as intended. If there's no colour tied to a dataset, it's given one from the default colourmap (nipy-spectral, not tab10)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #42
Very small change, but I think requires a colour to be tied to the signal process (e.g., with an entry in the
dataset_coloursblock or in thedataset_orderblock) to work properly. I don't think it will default to using the "original" colours (i.e., from matplotlib'stab10colourmap) if neither of the above blocks are specified