Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set tensor dtypes and use torch.tensor to initialize tensors in a2g #935

Merged
merged 1 commit into from
Dec 18, 2024
Merged

set tensor dtypes and use torch.tensor to initialize tensors in a2g #935

merged 1 commit into from
Dec 18, 2024

Conversation

lbluque
Copy link
Collaborator

@lbluque lbluque commented Dec 9, 2024

No description provided.

@lbluque lbluque requested review from misko and rayg1234 December 9, 2024 19:44
@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/fairchem/core/preprocessing/atoms_to_graphs.py 89.14% <100.00%> (ø)

... and 1 file with indirect coverage changes

@lbluque lbluque added the patch Patch version release label Dec 10, 2024
@lbluque lbluque added the minor Minor version release label Dec 17, 2024
misko
misko approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@misko misko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbluque lbluque added patch Patch version release bug Something isn't working and removed minor Minor version release patch Patch version release labels Dec 18, 2024
@lbluque lbluque added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 5959f5c Dec 18, 2024
8 of 16 checks passed
@lbluque lbluque deleted the a2g-tensor-init-fix branch December 18, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misko misko misko approved these changes

@rayg1234 rayg1234 Awaiting requested review from rayg1234

Assignees
No one assigned
Labels
bug Something isn't working patch Patch version release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbluque @misko