Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DGL to conda installer #911

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add DGL to conda installer #911

wants to merge 2 commits into from

Conversation

misko
Copy link
Collaborator

@misko misko commented Nov 12, 2024

No description provided.

@misko misko added enhancement New feature or request minor Minor version release labels Nov 12, 2024
@misko misko requested a review from rayg1234 November 12, 2024 21:50
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@rayg1234
Copy link
Collaborator

I tried installing with pip and it worked, do you have a pref for conda or pip in this case?

@lbluque
Copy link
Collaborator

lbluque commented Nov 14, 2024

If we are adding dgl as a fairchem-core dependency, can you add it to the pyproject.toml?

- defaults
dependencies:
- cpuonly
- pytorch>=2.4
- dgl
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specify version?

- defaults
dependencies:
- dgl
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor Minor version release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants