Skip to content
This repository has been archived by the owner on Feb 19, 2023. It is now read-only.

Commit

Permalink
Refactor
Browse files Browse the repository at this point in the history
Signed-off-by: Aravind V Nair <[email protected]>
  • Loading branch information
aravindvnair99 committed Feb 27, 2021
1 parent 531ff49 commit 8618246
Show file tree
Hide file tree
Showing 7 changed files with 86 additions and 83 deletions.
32 changes: 16 additions & 16 deletions CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,22 @@ appearance, race, religion, or sexual identity and orientation.
Examples of behavior that contributes to creating a positive environment
include:

* Using welcoming and inclusive language
* Being respectful of differing viewpoints and experiences
* Gracefully accepting constructive criticism
* Focusing on what is best for the community
* Showing empathy towards other community members
- Using welcoming and inclusive language
- Being respectful of differing viewpoints and experiences
- Gracefully accepting constructive criticism
- Focusing on what is best for the community
- Showing empathy towards other community members

Examples of unacceptable behavior by participants include:

* The use of sexualized language or imagery and unwelcome sexual attention or
advances
* Trolling, insulting/derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or electronic
address, without explicit permission
* Other conduct which could reasonably be considered inappropriate in a
professional setting
- The use of sexualized language or imagery and unwelcome sexual attention or
advances
- Trolling, insulting/derogatory comments, and personal or political attacks
- Public or private harassment
- Publishing others' private information, such as a physical or electronic
address, without explicit permission
- Other conduct which could reasonably be considered inappropriate in a
professional setting

## Our Responsibilities

Expand All @@ -55,7 +55,7 @@ further defined and clarified by project maintainers.
## Enforcement

Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported by contacting the project team at https://faceaseb.com/Team. All
reported by contacting the project team at <https://faceaseb.com/Team>. All
complaints will be reviewed and investigated and will result in a response that
is deemed necessary and appropriate to the circumstances. The project team is
obligated to maintain confidentiality with regard to the reporter of an incident.
Expand All @@ -68,9 +68,9 @@ members of the project's leadership.
## Attribution

This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
available at <https://www.contributor-covenant.org/version/1/4/code-of-conduct.html>

[homepage]: https://www.contributor-covenant.org

For answers to common questions about this code of conduct, see
https://www.contributor-covenant.org/faq
<https://www.contributor-covenant.org/faq>
12 changes: 6 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ All contributions are welcome! Code, documentation, softwares, scripts, graphics

Report [here](https://github.com/aravindvnair99/FACE-Amrita-Bengaluru/issues/new) in detail answering these questions:

* What steps did you take to make the bug appear?
* How can the bug be fixed? (In case you know)
* Which OS are you using?
* Have you tried any troubleshooting steps such as a reboot for example?
* Have you followed the prescribed prerequisites?
- What steps did you take to make the bug appear?
- How can the bug be fixed? (In case you know)
- Which OS are you using?
- Have you tried any troubleshooting steps such as a reboot for example?
- Have you followed the prescribed prerequisites?

# How do I contact the team?

Check [here](https://github.com/aravindvnair99/FACE-Amrita-Bengaluru/graphs/contributors) for the list of contributors. Contact one of them through their profiles.
Check [here](https://github.com/aravindvnair99/FACE-Amrita-Bengaluru/graphs/contributors) for the list of contributors. Contact one of them through their profiles.
12 changes: 6 additions & 6 deletions Prerequisite.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
# Prerequisites:
# Prerequisites

* npm
* Node.js
* Firebase
- npm
- Node.js
- Firebase

Check [here](https://github.com/aravindvnair99/FACE-Amrita-Bengaluru/network/dependencies) for the remaining prerequisites.

Check [here](https://github.com/aravindvnair99/FACE-Amrita-Bengaluru/blob/master/functions/package.json) for viewing the package.json file.

# Recommendations:
# Recommendations

* Visual Studio Code as text editor.
- Visual Studio Code as text editor.
24 changes: 12 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ This project is licensed under the MIT License - see the [LICENSE](LICENSE) file

# :family: Team

- **Abhishek Venkata Sai Kandikattu** - _Front-end Developer for FACE Amrita_ - [Abhishek-Sai](https://github.com/Abhishek-Sai)
- **Aravind V. Nair** - _Front-end, Back-end and DevOps for FACE, ACM and ACM-W of Amrita_ - [AravindVNair99](https://github.com/AravindVNair99)
- **Iyer Shreya Rajkumar** - _Front-end Developer for ACM-W Amrita_ - [Shreya1304](https://github.com/Shreya1304)
- **R Gomathi Priyaa** - _Front-end Developer for ACM-W Amrita_ - [PriyaaIyer](https://github.com/PriyaaIyer)
- **R K Subaharish** - _Front-end Developer for ACM and ACM-W of Amrita_ - [Subaharish](https://github.com/Subaharish)
- **Vinayak Tekade** - _Front-end Developer for ACM Amrita_ - [VinayakTekade](https://github.com/VinayakTekade)
- **Abhishek Venkata Sai Kandikattu** - _Front-end Developer for FACE_ - [Abhishek-Sai](https://github.com/Abhishek-Sai)
- **Aravind V. Nair** - _Front-end, Back-end and DevOps for FACE, ACM and ACM-W_ - [AravindVNair99](https://github.com/AravindVNair99)
- **Iyer Shreya Rajkumar** - _Front-end Developer for ACM-W_ - [Shreya1304](https://github.com/Shreya1304)
- **R Gomathi Priyaa** - _Front-end Developer for ACM-W_ - [PriyaaIyer](https://github.com/PriyaaIyer)
- **R K Subaharish** - _Front-end Developer for ACM and ACM-W_ - [Subaharish](https://github.com/Subaharish)
- **Vinayak Tekade** - _Front-end Developer for ACM_ - [VinayakTekade](https://github.com/VinayakTekade)

Note: Amrita refers to Amrita School of Engineering, Bengaluru.
Note: FACE, ACM and ACM-W here refers to the student chapter at Amrita School of Engineering, Bengaluru.

See the full list of [contributors](https://github.com/aravindvnair99/FACE-Amrita-Bengaluru/graphs/contributors) who participated in this project and statistics.

Expand All @@ -41,11 +41,11 @@ Check the [changelog here](https://github.com/aravindvnair99/FACE-Amrita-Bengalu

Report [here](https://github.com/aravindvnair99/FACE-Amrita-Bengaluru/issues/new/choose) in detail answering these questions:

- What steps did you take to make the bug appear?
- How can the bug be fixed? (In case you know)
- Which OS and which all packages/software/dependencies are you using?
- Have you tried any troubleshooting steps such as a reboot for example?
- Have you followed the prescribed prerequisites?
- What steps did you take to make the bug appear?
- How can the bug be fixed? (In case you know)
- Which OS and which all packages/software/dependencies are you using?
- Have you tried any troubleshooting steps such as a reboot for example?
- Have you followed the prescribed prerequisites?

# :envelope: How do I contact the team?

Expand Down
31 changes: 12 additions & 19 deletions public/offline.html
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
function gtag() {
dataLayer.push(arguments);
}
gtag('js', new Date());
gtag("js", new Date());

gtag('config', 'UA-126622119-1');
gtag("config", "UA-126622119-1");
</script>
<meta charset="utf-8" />
<meta name="author" content="Aravind V. Nair, Abhishek Sai" />
Expand Down Expand Up @@ -65,10 +65,7 @@
content="Offline - Forum for Aspiring Computer Engineers"
/>
<meta property="og:title" content="Offline - FACE Amrita Bangalore" />
<meta
property="og:url"
content="https://faceaseb.com/offline.html"
/>
<meta property="og:url" content="https://faceaseb.com/offline.html" />
<meta
property="og:description"
content="Offline - Forum for Aspiring Computer Engineers"
Expand Down Expand Up @@ -164,9 +161,7 @@
<ul class="slides">
<li>
<div class="flex-caption">
<h1 class="">
Offline &#x1f61f;
</h1>
<h1 class="">Offline &#x1f61f;</h1>
<h3 class="">
The content you are looking for couldn't
be found. Please check your connection
Expand Down Expand Up @@ -201,7 +196,7 @@ <h1>Get In Touch With Us<span>.</span></h1>
id="contactName"
placeholder="Name"
value=""
minLength="2"
minlength="2"
required
/>
</div>
Expand Down Expand Up @@ -300,7 +295,7 @@ <h3>Contact Numbers:</h3>
target="_blank"
rel="noopener"
href="https://www.instagram.com/face_aseb/"
><i class="fa fa-instagram "></i
><i class="fa fa-instagram"></i
></a>
</li>
<li>
Expand Down Expand Up @@ -328,9 +323,7 @@ <h3>Contact Numbers:</h3>
<hr />
<div class="info">
<div class="footer-logo"></div>
<p>
FACE | Amrita School of Engineering, Bangalore
</p>
<p>FACE | Amrita School of Engineering, Bangalore</p>
</div>
</div>
<ul class="copyright">
Expand Down Expand Up @@ -382,16 +375,16 @@ <h3>Contact Numbers:</h3>
<script>
if (navigator.serviceWorker.controller) {
console.log(
'[PWA Builder] active service worker found, no need to register'
"[PWA Builder] active service worker found, no need to register"
);
} else {
navigator.serviceWorker
.register('pwabuilder-sw.js', {
scope: './'
.register("pwabuilder-sw.js", {
scope: "./",
})
.then(function(reg) {
.then(function (reg) {
console.log(
'Service worker has been registered for scope:' +
"Service worker has been registered for scope:" +
reg.scope
);
});
Expand Down
56 changes: 33 additions & 23 deletions public/pwabuilder-sw.js
Original file line number Diff line number Diff line change
@@ -1,34 +1,44 @@
//This is the "Offline page" service worker

//Install stage sets up the offline page in the cache and opens a new cache
self.addEventListener('install', function(event) {
var offlinePage = new Request('offline.html');
event.waitUntil(
fetch(offlinePage).then(function(response) {
return caches.open('pwabuilder-offline').then(function(cache) {
console.log('[PWA Builder] Cached offline page during Install'+ response.url);
return cache.put(offlinePage, response);
});
}));
self.addEventListener("install", function (event) {
var offlinePage = new Request("offline.html");
event.waitUntil(
fetch(offlinePage).then(function (response) {
return caches.open("pwabuilder-offline").then(function (cache) {
console.log(
"[PWA Builder] Cached offline page during Install" +
response.url
);
return cache.put(offlinePage, response);
});
})
);
});

//If any fetch fails, it will show the offline page.
//Maybe this should be limited to HTML documents?
self.addEventListener('fetch', function(event) {
event.respondWith(
fetch(event.request).catch(function(error) {
console.error( '[PWA Builder] Network request Failed. Serving offline page ' + error );
return caches.open('pwabuilder-offline').then(function(cache) {
return cache.match('offline.html');
});
}
));
self.addEventListener("fetch", function (event) {
event.respondWith(
fetch(event.request).catch(function (error) {
console.error(
"[PWA Builder] Network request Failed. Serving offline page " +
error
);
return caches.open("pwabuilder-offline").then(function (cache) {
return cache.match("offline.html");
});
})
);
});

//This is a event that can be fired from your page to tell the SW to update the offline page
self.addEventListener('refreshOffline', function(response) {
return caches.open('pwabuilder-offline').then(function(cache) {
console.log('[PWA Builder] Offline page updated from refreshOffline event: '+ response.url);
return cache.put(offlinePage, response);
});
self.addEventListener("refreshOffline", function (response) {
return caches.open("pwabuilder-offline").then(function (cache) {
console.log(
"[PWA Builder] Offline page updated from refreshOffline event: " +
response.url
);
return cache.put(offlinePage, response);
});
});
2 changes: 1 addition & 1 deletion public/sitemap.xml
Original file line number Diff line number Diff line change
Expand Up @@ -168,4 +168,4 @@
<priority>0.80</priority>
</url>

</urlset>
</urlset>

0 comments on commit 8618246

Please sign in to comment.