Implement Sync Rules

[SferaDev]

📌 References

• Issue: Close Implement sync rules #15

📝 Implementation

• Add two new routes to access the new pages

• Add Sync Rules Landing Page

• Add Sync Rules Creation Wizard

  • Add General Info Step with a simple form

  • Add Metadata Selection Step with ObjectsTable that allows any type of metadata

  • Add Instance Selection Step with a multiselector

  • Add Save Step with a Summary of the Sync Rule to save in the dataStore

• Update dropdown to allow hiding default value and fixing bug where it goes off-screen

• Move getValueForCollection method to utils and re-use it in the new components

• Fix bug in datastore that crashed when searching in non-strings

• Add a new list by id logic method that does not require knowing the metadata type

• Allow setting the fields when accessing the metadata endpoint

🎨 Screenshots

🔥 Is there anything the reviewer should know to test it?

📑 Others

• Any dependencies from other projects?
  • Import Wizard from vaccination-app d2-ui-components#41
  • Add initial selection to Objects Table d2-ui-components#42
  • Set a default autoHide only for success messages d2-ui-components#43
  • Add vertical align to data table d2-ui-components#44

[tokland]

Works nicely! Some comments:

[tokland]

If the structure name/id won't change, we could do it programmatically in a loop.

[tokland]

I guess the idea was to keep the same structure in the app and DB So let's do this only if it really makes sense to reduce the size of the persisted object.

[SferaDev]

Will do in another PR, we might extract the models altogether and pass them as a prop

[tokland]

Cool! I know at the beginning it feels cumbersome, but in my experience it pays off, on the long run, to have fully immutable models. By the way, this kind of boilerplate for nested updates can be simplified using lodash.fp, (_.set), but please don't change it, the method is not fully typed and we lose safety. There is a functional pattern to work with nested structures called "lenses". For TS, this is the best I know: https://github.com/utatti/lens.ts. Again, don't change it, just as a note, it's perfectly fine as it is, with just a level of nesting.

[SferaDev]

WIll take a look on this lenses concept!

[adrianq]

First of all, let me say that this incredible work! Thanks for this. A few minor comments (some of them already discussed):

• List of target instances should display as separated commas list
• Left click on a row forward to the edit feature. While in the other sync section it goes to Details. Although in latest versions of DHIS2 the first option is the implemented one, in general, unless you have a strong opinion in a different sense I will choose 'Details' as the left click action.
• Remove asterisk and use compulsory fields instead
• If you click on 'Clear Selection' probably is better to clear up all the filters (including the selected checkbox) and refresh, right?

I am merging this anyway as it is a huge PR and I don't want to postpone it anymore. Feel free to create issues if you agree with my comments or let me know otherwise!