add automatic persisted queries implementation to client #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszkuc
reviewed
Jun 23, 2023
.../src/main/kotlin/com/expediagroup/graphql/client/types/AutomaticPersistedQueriesExtension.kt
Outdated
Show resolved
Hide resolved
dariuszkuc
reviewed
Jun 23, 2023
...t/src/main/kotlin/com/expediagroup/graphql/client/types/AutomaticPersistedQueriesSettings.kt
Outdated
Show resolved
Hide resolved
dariuszkuc
reviewed
Jun 23, 2023
...kotlin-ktor-client/src/main/kotlin/com/expediagroup/graphql/client/ktor/GraphQLKtorClient.kt
Outdated
Show resolved
Hide resolved
|
@dariuszkuc |
...t/src/main/kotlin/com/expediagroup/graphql/client/types/AutomaticPersistedQueriesSettings.kt
Show resolved
Hide resolved
samuelAndalon
added
changes: minor
...ain/kotlin/com/expediagroup/graphql/client/extensions/AutomaticPersistedQueriesExtensions.kt
Show resolved
Hide resolved
...t/src/main/kotlin/com/expediagroup/graphql/client/types/AutomaticPersistedQueriesSettings.kt
Outdated
Show resolved
Hide resolved
|
@gumimin can you take a look at the build failure, i think its coverage, we might need to add a test for GET and POST |
|
@samuelAndalon |
gumimin
force-pushed
the
automatic-persisted-queries
branch
from
5353d1d to
5619ee9
Compare
gumimin
force-pushed
the
automatic-persisted-queries
branch
from
5619ee9 to
ee738ba
Compare
|
@samuelAndalon |
samuelAndalon
approved these changes
Jul 3, 2023
|
@gumimin Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Related Issues
#1640