Fix message storage of recorded at for mysql 8.0 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frankdejonge @rahmanii0 Curious about the vision you both have in regards to the versioning of this package. Since EventSauce .8 to 1.2 introduced some breaking changes, I think it would be easier for maintenance of this package to follow EventSauce's major version bump. If we don't do this, we'll end up with If checks through this package in order to support all versions. |
Robertbaelde
changed the title
|
@Robertbaelde I think it makes sense to drop 0.8 and bump the major version up. |
|
Do we still need to do this if we replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change in the
LaravelMessageRepositorywill fix the issue with mysql8 datetime:Issue in LaravelEventSauce #25
"parent" issue in EventSauce: EventSaucePHP/EventSauce#108
I'm aware of the
MySQL8DateFormattingbut I think formatting the date in the right way for the storage should be a concern of the repository.Besides that, I think this would improve the onboarding experience of new users of this package.