Fix incorrect aggregate root ID type on AggregateRootWithAggregates
#225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this fix?
The
AggregateRootWithAggregates
breaks type inference for the aggregate root's ID. When using this trait PHPStan will always infer the type asEventSauce\EventSourcing\AggregateRootId
For example:
With this PR you'd have to add
FooId
to the@use
statement, after which$this->aggregateRootId()
would be typed asFooId
.Something to take note of
While this fixes the mistyping completely, it could be considered a breaking change as adding a new template to a trait will surely cause some PHPStan workflows to fail.