Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document units for ExponentialBackOffStrategy parameters #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oxan
Copy link

@oxan oxan commented Nov 8, 2024

"ms" is commonly understood to be milliseconds, but is used for microseconds (commonly denoted as us) here. Add a docblock to make it clear that this deviates from the convention.

I opted not to change the argument name, as with named arguments that would be a backward compatibility break.

"ms" is commonly understood to be milliseconds, but is used for
microseconds (commonly denoted as us) here. Add a docblock to make it
clear that this deviates from the convention.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant