Implementation of the debug_getAccessibleState and debug_dbGet methods #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novosandara
requested review from
Stefan-Ethernal,
goran-ethernal and
oliverbundalo
| // of the next block. | ||
| // The (from, to) parameters are the sequence of blocks to search, which can go | ||
| // either forwards or backwards | ||
| func (d *Debug) GetAccessibleState(from, to BlockNumber) (interface{}, error) { |
There was a problem hiding this comment.
return uint64 instead of interface
| // DbGet returns the raw value of a key stored in the database. | ||
| // | ||
| //nolint:stylecheck | ||
| func (d *Debug) DbGet(key string) (interface{}, error) { |
There was a problem hiding this comment.
Return []byte instead of interface.
There is a question from which database data needs to be returned, state or blockchain? IMO we should check both, but in that case we need to extend blockchain API with Get method. Although it's not complicated I am not sure if it's worth it. For now we can keep it this way, returning value only from state DB.
| @@ -74,6 +74,10 @@ func (s *Snapshot) GetCode(hash types.Hash) ([]byte, bool) { | |||
| return s.state.GetCode(hash) | |||
| } | |||
|
|
|||
| func (s *Snapshot) Get(hash types.Hash) ([]byte, bool, error) { | |||
There was a problem hiding this comment.
There is no need for this method.
| @@ -30,6 +30,7 @@ type readSnapshot interface { | |||
| GetStorage(addr types.Address, root types.Hash, key types.Hash) types.Hash | |||
| GetAccount(addr types.Address) (*Account, error) | |||
| GetCode(hash types.Hash) ([]byte, bool) | |||
| Get(hash types.Hash) ([]byte, bool, error) | |||
There was a problem hiding this comment.
There is no need for this method.
| @@ -47,6 +47,14 @@ func (m *mockSnapshot) GetCode(hash types.Hash) ([]byte, bool) { | |||
| return nil, false | |||
| } | |||
|
|
|||
| func (m *mockSnapshot) Has(hash types.Hash) bool { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of the debug_getAccessibleState and debug_dbGet methods
Changes include
Breaking changes
Checklist
Testing
Manual tests
Documentation update
Additional comments