forked from 0xPolygon/polygon-edge
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate different features in polybft
package to separate packages
#383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
force-pushed
the
separate-to-packages
branch
9 times, most recently
from
September 26, 2024 14:02
ddc702f
to
89a1aad
Compare
goran-ethernal
requested review from
oliverbundalo,
Stefan-Ethernal and
dusannosovic-ethernal
September 26, 2024 14:26
goran-ethernal
force-pushed
the
separate-to-packages
branch
2 times, most recently
from
September 27, 2024 08:58
f2de8f1
to
25521bd
Compare
dusannosovic-ethernal
approved these changes
Sep 27, 2024
goran-ethernal
force-pushed
the
separate-to-packages
branch
2 times, most recently
from
September 27, 2024 09:20
a510f0b
to
2520523
Compare
oliverbundalo
approved these changes
Sep 27, 2024
Stefan-Ethernal
approved these changes
Sep 27, 2024
consensus/polybft/proposer/state_store_proposer_snapshot_test.go
Outdated
Show resolved
Hide resolved
goran-ethernal
force-pushed
the
separate-to-packages
branch
from
September 30, 2024 07:37
17c61a4
to
009b40b
Compare
goran-ethernal
force-pushed
the
separate-to-packages
branch
from
September 30, 2024 13:14
009b40b
to
1a0f9d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New packages in
polybft
blockchain
- containsblock_wrapper
,block_builder
logic.bridge
- contains all the bridge logic.config
- containspolybft
config structures and helper functions used to save thepolybft
config togenesis
file, and reading it.governance
- contains all the governance logic.helper
- contains helper functions used across the polybft packages.metrics
- contains helper functions to increment different metrics inpolybft
.proposer
- containsproposer_calculator
andproposer_snapshot
logic.stake
- contains thestake_manager
logic.state
- contains the logic for creatingdb
for saving different offchain data inpolybft
.system_state
- contains all thesystemState
logic.testing
- contains mocked structures.types
- contains commonpolybft
types used throughoutpolybft
(for example,Extra
).validator-snapshot
- contains all the logic aroundvalidator snapshots
.What logic was changed
persistance store
now have their ownstate_store
file, and those stores are not initialized like before in the globalstate
instance. Globalstate
instance now only opens a db. The rest of the stores now use thedb
instance from the globalstate
instance to initialize their buckets.mocks
are now in themocks
package.The rest of the logic is basically the same, and was not changed.
How to review
Most of the changes are just package name changes. Only focus on the points in the previous section.
Changes include
Checklist
Testing