Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixed transaction to different types of transactions #102

Merged
merged 18 commits into from
Feb 23, 2024
Merged

Mixed transaction to different types of transactions #102

merged 18 commits into from
Feb 23, 2024

Conversation

dusannosovic-ethernal
Copy link

Description

Instead of having only mixedTx, this PR introduce different type for each type of transaction through TxData interface.

It's inlcludes four types of transactions:

  • StateTx
  • LegacyTx
  • DynamicFeeTx
  • AccessListTx

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@dusannosovic-ethernal dusannosovic-ethernal self-assigned this Feb 7, 2024
@dusannosovic-ethernal dusannosovic-ethernal marked this pull request as ready for review February 7, 2024 13:32
goran-ethernal
goran-ethernal reviewed Feb 7, 2024
View reviewed changes
blockchain/blockchain_test.go Outdated Show resolved Hide resolved
jsonrpc/helper.go Show resolved Hide resolved
state/transition_test.go Outdated Show resolved Hide resolved
tests/state_test_util.go Outdated Show resolved Hide resolved
txpool/txpool.go Outdated Show resolved Hide resolved
types/legacy_tx.go Outdated Show resolved Hide resolved
types/rlp_encoding_test.go Outdated Show resolved Hide resolved
types/rlp_marshal_storage.go Outdated Show resolved Hide resolved
types/rlp_unmarshal.go Outdated Show resolved Hide resolved
types/rlp_unmarshal_storage.go Outdated Show resolved Hide resolved
goran-ethernal
goran-ethernal previously approved these changes Feb 12, 2024
View reviewed changes
Stefan-Ethernal
Stefan-Ethernal reviewed Feb 13, 2024
View reviewed changes
Copy link

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall really nice 🚀. Leaving some comments to consider reusing some more logic.

types/transaction.go Outdated Show resolved Hide resolved
txpool/txpool.go Show resolved Hide resolved
tests/state_test_util.go Outdated Show resolved Hide resolved
jsonrpc/types.go Show resolved Hide resolved
types/legacy_tx.go Show resolved Hide resolved
types/dynamic_fee_tx.go Outdated Show resolved Hide resolved
types/rlp_unmarshal_storage.go Outdated Show resolved Hide resolved
types/dynamic_fee_tx.go Outdated Show resolved Hide resolved
@dusannosovic-ethernal dusannosovic-ethernal force-pushed the introduce-better-abstraction-for-the-transactions branch from be89200 to fec4957 Compare February 13, 2024 11:43
@Stefan-Ethernal Stefan-Ethernal force-pushed the introduce-better-abstraction-for-the-transactions branch from a82b6e8 to dec21ec Compare February 13, 2024 14:23
Base automatically changed from feature/berlin to develop February 19, 2024 11:04
@goran-ethernal goran-ethernal dismissed their stale review February 19, 2024 11:04

The base branch was changed.

@Stefan-Ethernal Stefan-Ethernal force-pushed the introduce-better-abstraction-for-the-transactions branch from dec21ec to f546ff1 Compare February 19, 2024 11:40
@goran-ethernal goran-ethernal force-pushed the introduce-better-abstraction-for-the-transactions branch from ba92eaa to 2c99ad9 Compare February 22, 2024 13:52
@goran-ethernal goran-ethernal merged commit ca993c5 into develop Feb 23, 2024
9 checks passed
@goran-ethernal goran-ethernal deleted the introduce-better-abstraction-for-the-transactions branch February 23, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@Stefan-Ethernal Stefan-Ethernal Awaiting requested review from Stefan-Ethernal

Assignees

@dusannosovic-ethernal dusannosovic-ethernal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dusannosovic-ethernal @Stefan-Ethernal @goran-ethernal