Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IBFT consensus protocol #1

Merged
merged 15 commits into from
Nov 9, 2023
Merged

Remove IBFT consensus protocol #1

merged 15 commits into from
Nov 9, 2023

Conversation

Stefan-Ethernal
Copy link

@Stefan-Ethernal Stefan-Ethernal commented Nov 7, 2023 •
edited
Loading

Description

Remove all IBFT-related stuff.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Stefan-Ethernal Stefan-Ethernal mentioned this pull request Nov 7, 2023
Closed
@Ethernal-Tech Ethernal-Tech deleted a comment from CLAassistant Nov 8, 2023
@goran-ethernal goran-ethernal requested a review from a team November 8, 2023 10:18
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review November 8, 2023 10:28
goran-ethernal
goran-ethernal reviewed Nov 8, 2023
View reviewed changes
command/common.go Outdated Show resolved Hide resolved
goran-ethernal
goran-ethernal reviewed Nov 8, 2023
View reviewed changes
command/common.go Outdated Show resolved Hide resolved
command/common.go Outdated Show resolved Hide resolved
command/genesis/genesis.go Outdated Show resolved Hide resolved
e2e/framework/config.go Outdated Show resolved Hide resolved
e2e/framework/config.go Outdated Show resolved Hide resolved
@Stefan-Ethernal Stefan-Ethernal changed the title Remove IBFT consensus protocol from edge Remove IBFT consensus protocol Nov 8, 2023
goran-ethernal
goran-ethernal previously approved these changes Nov 9, 2023
View reviewed changes
@Stefan-Ethernal Stefan-Ethernal merged commit 643d5d7 into develop Nov 9, 2023
8 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-871-remove-ibft-consensus-protocol-from-edge branch November 9, 2023 14:19
bane added a commit that referenced this pull request Mar 14, 2024
@bane
Deploy Network (#1)
eef2330
@oliverbundalo oliverbundalo mentioned this pull request Apr 12, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@igorcrevar igorcrevar

@Stefan-Ethernal Stefan-Ethernal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stefan-Ethernal @goran-ethernal @igorcrevar