Skip to content

Commit

Permalink
lint fix
Browse files Browse the repository at this point in the history
  • Loading branch information
goran-ethernal committed Sep 10, 2024
1 parent 2e7d3c3 commit d170589
Show file tree
Hide file tree
Showing 4 changed files with 31 additions and 26 deletions.
14 changes: 7 additions & 7 deletions command/bridge/deploy/internal_contracts.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//nolint:dupl
package deploy

import (
Expand All @@ -23,7 +24,8 @@ var (

// initInternalContracts initializes the internal contracts
func initInternalContracts(o command.OutputFormatter, chainCfg *chain.Chain) {
useBridgeAllowList, useBridgeBlockList := chainCfg.Params.DoesItUseBridgeAllowList(), chainCfg.Params.DoesItUseBridgeBlockList()
useBridgeAllowList, useBridgeBlockList := chainCfg.Params.DoesItUseBridgeAllowList(),
chainCfg.Params.DoesItUseBridgeBlockList()

internalContracts = make([]*contract, 0)

Expand Down Expand Up @@ -320,12 +322,10 @@ func initInternalContracts(o command.OutputFormatter, chainCfg *chain.Chain) {
})
}

// preAllocateInternalPredicates pre-allocates internal predicates in genesis if the command is run in bootstrap mode
func preAllocateInternalPredicates(o command.OutputFormatter, chainCfg *chain.Chain, bridgeCfg *polybft.BridgeConfig) error {
if _, err := o.Write([]byte("[BRIDGE - DEPLOY] Pre-allocating internal predicates in bootstrap mode\n")); err != nil {
return err
}

// preAllocateInternalPredicates pre-allocates internal predicates in genesis
// if the command is run in bootstrap mode
func preAllocateInternalPredicates(o command.OutputFormatter,
chainCfg *chain.Chain, bridgeCfg *polybft.BridgeConfig) error {
predicateBaseProxyAddress := contracts.ChildBridgeContractsBaseAddress
if consensusCfg.Bridge != nil {

Check failure on line 330 in command/bridge/deploy/internal_contracts.go

View workflow job for this annotation

GitHub Actions / Lint / Run Lint

if statements should only be cuddled with assignments used in the if statement itself (wsl)
for _, bridgeCfg := range consensusCfg.Bridge {
Expand Down
9 changes: 6 additions & 3 deletions consensus/polybft/contracts_initializer.go
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,8 @@ func initERC20ACLPredicateContract(
return nil
}

input, err := getInitERC20PredicateACLInput(bcfg, owner, useBridgeAllowList, useBridgeBlockList, childMintable, chainID)
input, err := getInitERC20PredicateACLInput(bcfg, owner,
useBridgeAllowList, useBridgeBlockList, childMintable, chainID)
if err != nil {
return err
}
Expand Down Expand Up @@ -453,7 +454,8 @@ func initERC721ACLPredicateContract(
return nil
}

input, err := getInitERC721PredicateACLInput(bcfg, owner, useBridgeAllowList, useBridgeBlockList, childMintable, chainID)
input, err := getInitERC721PredicateACLInput(bcfg, owner,
useBridgeAllowList, useBridgeBlockList, childMintable, chainID)
if err != nil {
return err
}
Expand Down Expand Up @@ -486,7 +488,8 @@ func initERC1155ACLPredicateContract(
return nil
}

input, err := getInitERC1155PredicateACLInput(bcfg, owner, useBridgeAllowList, useBridgeBlockList, childMintable, chainID)
input, err := getInitERC1155PredicateACLInput(bcfg, owner,
useBridgeAllowList, useBridgeBlockList, childMintable, chainID)
if err != nil {
return err
}
Expand Down
28 changes: 14 additions & 14 deletions consensus/polybft/polybft_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,32 +166,32 @@ type BridgeConfig struct {

// GetHeighestInternalAddress returns the highest address among all internal bridge contracts
func (b *BridgeConfig) GetHeighestInternalAddress() types.Address {
heighest := b.InternalGatewayAddr
if b.InternalERC20PredicateAddr.Compare(heighest) > 0 {
heighest = b.InternalERC20PredicateAddr
result := b.InternalGatewayAddr
if b.InternalERC20PredicateAddr.Compare(result) > 0 {
result = b.InternalERC20PredicateAddr
}

if b.InternalERC721PredicateAddr.Compare(heighest) > 0 {
heighest = b.InternalERC721PredicateAddr
if b.InternalERC721PredicateAddr.Compare(result) > 0 {
result = b.InternalERC721PredicateAddr
}

if b.InternalERC1155PredicateAddr.Compare(heighest) > 0 {
heighest = b.InternalERC1155PredicateAddr
if b.InternalERC1155PredicateAddr.Compare(result) > 0 {
result = b.InternalERC1155PredicateAddr
}

if b.InternalMintableERC20PredicateAddr.Compare(heighest) > 0 {
heighest = b.InternalMintableERC20PredicateAddr
if b.InternalMintableERC20PredicateAddr.Compare(result) > 0 {
result = b.InternalMintableERC20PredicateAddr
}

if b.InternalMintableERC721PredicateAddr.Compare(heighest) > 0 {
heighest = b.InternalMintableERC721PredicateAddr
if b.InternalMintableERC721PredicateAddr.Compare(result) > 0 {
result = b.InternalMintableERC721PredicateAddr
}

if b.InternalMintableERC1155PredicateAddr.Compare(heighest) > 0 {
heighest = b.InternalMintableERC1155PredicateAddr
if b.InternalMintableERC1155PredicateAddr.Compare(result) > 0 {
result = b.InternalMintableERC1155PredicateAddr
}

return heighest
return result
}

func (p *PolyBFTConfig) IsBridgeEnabled() bool {
Expand Down
6 changes: 4 additions & 2 deletions types/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,10 @@ func IncrementAddressBy(addr Address, increment uint64) Address {
addrBigInt.Add(addrBigInt, big.NewInt(0).SetUint64(increment))

// Convert back to Address
var newAddr Address
addrBytes := addrBigInt.Bytes()
var (
newAddr Address
addrBytes = addrBigInt.Bytes()
)

// Handle overflow by truncating to 20 bytes
if len(addrBytes) > 20 {
Expand Down

0 comments on commit d170589

Please sign in to comment.