Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support try-with-resources in Java 7+ for YamlWriter and YamlReader #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support try-with-resources in Java 7+ for YamlWriter and YamlReader #69

wants to merge 1 commit into from

Conversation

eburtsev
Copy link

Closes #62

@AndrewTasso
Copy link

Any word on getting this PR deconflicted and merged? It would be nice to have!

@Mr14huashao
Copy link
Collaborator

YamlWriter.close() is not simply releasing resources, the important thing is to convert the input object into yaml format and write it to the stream.

YamlReader.close() is to close the stream and release resources, this can implement Closeable interface.
@NathanSweet
YamlWriter and YamlReader needs to implement the Closeable interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

YamlWriter and YamlReader do not implement Closeable
3 participants
@eburtsev @AndrewTasso @Mr14huashao