: Add EccNodeSync class #685
Conversation
There was a problem hiding this comment.
I think we need to expose it as Configuration, like RepairHistory, it would receive the nativeConnectionProvider bean and get the nodes to populate in the startup. I just don't know if we can define optional configurations based on the nativeConnectionProvider that we are using.
| } | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Remove empty lines
| node.getHostId()); | ||
| } | ||
|
|
||
| @VisibleForTesting |
There was a problem hiding this comment.
I'd say that you can let it as public, as we'd use this method to populate initial nodes state on cassandra
| public class EccNodesSyncTest | ||
| { | ||
| @Mock | ||
| private CqlSession mockSession; |
There was a problem hiding this comment.
Add empty line between the fields
|
@manmagic3 plese refer the issue id and include your changes on the docs |
|
As Manish didn't had time to finish it, I finished as my next task depends on this, the patch will be done in a separate PR |
This class is for inserting/iterating Node sync data