Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add render function for usage not from command line + wrong fix for #16 #17

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pietroppeter
Copy link

the first commit:

  • refactors render functions
  • add type RenderOptions
  • add a render function that can create a video without the need to pass command line options

the above was useful for me to create a nanim animation for today's advent of code: https://pietroppeter.github.io/adventofnim/2021/day07.html

as mentioned in #16 the fix in the second commit, although it seems wrong, improved a bit my situation and allowed me to complete the task. Once a better fix (or an explanation fo behavior) is available, we could merge all this. For the moment this is a draft.

Have a good day and thanks again for nanim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant