Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert test case to nightly mode #1669

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ccuser44
Copy link
Contributor

@ccuser44 ccuser44 commented Nov 3, 2024

Experimental features should be based on nightly status not debugmode.

@Dimenpsyonal
Copy link
Member

DebugMode seems more appropriate for this cuz people might have forks that don't use nightly for testing

@ccuser44
Copy link
Contributor Author

Experimental features should be based on nightly status not debugmode.

That May be right. I'll let a maintainer decide

PoF:
image

@ccuser44
Copy link
Contributor Author

ccuser44 commented Nov 19, 2024

DebugMode seems more appropriate for this cuz people might have forks that don't use nightly for testing

Maybe. Originally though it should have used NightlyMode in the first place but it didn't exist back then. It was there was a part of a rollout (scel said no to the progressive time based rollout code but the toggle was left) test as an experimental feature and nightlymode should be the toggle for experimental features.
Honestly the setting toggle could be removed totally, and frankly even the whole serverside character AC could too. But maybe not for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants