Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coven (New Faction... again....) #1245

Open
wants to merge 361 commits into
base: dev_2.2.0_sub
Choose a base branch
from

Conversation

MargaretTheFool
Copy link
Contributor

@MargaretTheFool MargaretTheFool commented Oct 1, 2024

this is nowhere near finished but i might as well make a pr for it
https://docs.google.com/document/d/1KaBjn6qk5NqUC7Ax7uQxXY1C9wsswWH__rBdzrZCd1I/edit?usp=sharing

@MargaretTheFool MargaretTheFool marked this pull request as draft October 1, 2024 21:47
@MargaretTheFool MargaretTheFool changed the title Happy Halloween! Coven (New Faction... again....) Oct 1, 2024
@Tommy-XL Tommy-XL added the New Role/Add-on New role added label Oct 2, 2024
@Tommy-XL Tommy-XL changed the base branch from DevBuild_2.1.0 to main October 27, 2024 08:51
@MargaretTheFool
Copy link
Contributor Author

Conjurer, Coven Leader, Medusa, Moon Dancer, Ritualist, and Voodoo Master work perfectly fine
Illusionist works good but is buggy on some role interactions
Sacrifist is very buggy
Hex Master, Jinx, Necromancer, Poisoner, Potion Master have not been changed yet
Dreamweaver, Sorceress, and Spellcaster have not been coded at all yet
Sorceress was Drakos's idea that he wanted to code so that wont be touched at all.
I can't code Dreamweaver until EnhancedNetwork/TownofHost-Enhanced#1222 gets merged.
I might scrap Spellcaster
The Necronomicon Mechanic is buggy
Guessing Menu is completely broken and voting doesn't work half the time and I can't figure out why

@MargaretTheFool
Copy link
Contributor Author

i did NOT do that

@MargaretTheFool
Copy link
Contributor Author

voting and guessing dont work but everything else does as far as I know, im gonna need someone else to fix this for me
here's the proof:

Screen.Recording.2024-11-10.132412.mp4

TOHE-v2024.1103.211.9999-2024-11-10_13.24.37.log

@MargaretTheFool MargaretTheFool marked this pull request as ready for review November 11, 2024 23:59
@MargaretTheFool
Copy link
Contributor Author

I fixed voting last night but I'm still not sure why the guessing menu won't populate roles

@MargaretTheFool
Copy link
Contributor Author

oh my GOD i finally fixed it it was one stupid variable

@NikoCat233 NikoCat233 changed the base branch from main to dev_2.2.0 November 22, 2024 18:07
@NikoCat233
Copy link
Collaborator

conflicts

@NikoCat233 NikoCat233 marked this pull request as draft November 26, 2024 15:36
Copy link
Collaborator

@NikoCat233 NikoCat233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roles/Coven/Sorceress.cs this file is empyt

I did a very little brief review and some of my reviews may be wrong, more bugs should remain undiscovered

Bruh this is a huge pr dude. I would rather prefer it be spilt to small prs, like first add a coven base, then add the roles one by one

Modules/OptionItem/OptionItem.cs Show resolved Hide resolved
Modules/RPC.cs Outdated Show resolved Hide resolved
Modules/Utils.cs Outdated Show resolved Hide resolved
Patches/MeetingHudPatch.cs Show resolved Hide resolved
Roles/AddOns/Common/Oiiai.cs Show resolved Hide resolved
Roles/Coven/CovenManager.cs Show resolved Hide resolved
Roles/Coven/HexMaster.cs Show resolved Hide resolved
Roles/Coven/Jinx.cs Show resolved Hide resolved
Roles/Coven/Jinx.cs Show resolved Hide resolved
Roles/Coven/Ritualist.cs Show resolved Hide resolved
@MargaretTheFool
Copy link
Contributor Author

MargaretTheFool commented Nov 26, 2024

Roles/Coven/Sorceress.cs this file is empyt

drakos was going to code Sorceress but he is on an infinite hiatus, should I remove the file

@MargaretTheFool MargaretTheFool marked this pull request as ready for review November 30, 2024 19:01
@NikoCat233
Copy link
Collaborator

Sorry, i performed code cleaning and it fucked up every roles

@MargaretTheFool
Copy link
Contributor Author

Sorry, i performed code cleaning and it fucked up every roles

bruh

I guess I'll fix it when I get home

@MargaretTheFool
Copy link
Contributor Author

that was really annoying

@NikoCat233
Copy link
Collaborator

Too hard to review, i gonna release a external build to test this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Role/Add-on New role added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants