Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The benchmark cache is not invalidated when data changes #95

Open
glpuga opened this issue Aug 16, 2024 · 1 comment
Open

The benchmark cache is not invalidated when data changes #95

glpuga opened this issue Aug 16, 2024 · 1 comment
Labels
bug Something isn't working needs-fix Bug confirmed, need a fix

Comments

@glpuga
Copy link
Collaborator

glpuga commented Aug 16, 2024

Bug description

After a failed and resumed run, the report generation totally ignored one of the five datasets and generated no data for it.

The issue was due to the benchmark cache having become stale, and not getting updated when, on the resumed run, the last dataset output data was added after having been absent when the first run failed.

The issue was fixed by removing the cache file after confirming in the code that it would be regenerated.

How to reproduce

I guess that anything that fills the cache and then changes data will do

Expected behavior

The cache should have some clear invalidation criteria.

The best one for this use case is probably the complete invalidation of the cache contents on each run of the command.

Actual behavior

The cache keeps state across runs of shepherd, causing stale data to be used instead of actual state.

Additional context

.

@glpuga glpuga added the bug Something isn't working label Aug 16, 2024
@hidmic hidmic added the needs-fix Bug confirmed, need a fix label Oct 24, 2024
@hidmic
Copy link
Collaborator

hidmic commented Oct 24, 2024

Indeed. DataFrame caching is not paying attention to the data source because it doesn't know about it. It should at least pick up what the target iterations are for the underlying function and perform a timestamp check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-fix Bug confirmed, need a fix
Projects
None yet
Development

No branches or pull requests

2 participants