Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistencies in ROS resource keywords #57

Open
nahueespinosa opened this issue May 21, 2023 · 0 comments
Open

Fix inconsistencies in ROS resource keywords #57

nahueespinosa opened this issue May 21, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@nahueespinosa
Copy link
Member

Feature description

After adding basic ROS 2 orchestration support in the form of a Robot Framework support library in #54, we noticed a couple of issues with the keyword definition and collisions with ROS 1:

  • Some keywords would do exactly the same thing in both versions and they were de-duplicated in a ros_common resource.
  • Other keywords would need to do different things depending on the version and they were disambiguated by adding "ROS 2" to their name.

There are still some inconsistencies though, e.g. keywords that explicitly name ROS could be used for both ROS 1 and ROS 2. For example:

Uses ${launch_file} in ${package_name} ROS package as rig

There is also the idea of adding sugar on top to route to the right version.

@nahueespinosa nahueespinosa added the enhancement New feature or request label May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant