Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantics, semantics, semantics #45

Closed
hidmic opened this issue May 5, 2023 · 0 comments · Fixed by #46
Closed

Semantics, semantics, semantics #45

hidmic opened this issue May 5, 2023 · 0 comments · Fixed by #46
Labels
meta needs-work Ready to be worked on

Comments

@hidmic
Copy link
Collaborator

hidmic commented May 5, 2023

Discussed in https://github.com/ekumenlabs/lambkin/discussions/41

Originally posted by hidmic April 12, 2023
During #35, I came to the realization that some of the naming we use in LAMBKIN is inadequate and confusing.

  • LAMBKIN, the repository. As long as LAMBKIN remains a monorepo project, it is reasonable to have an homonym repository hosting the components and tools that make up the toolkit.
  • lambkin, the package. This is a misnomer. This package is not the toolkit, it is an orchestration tool that is part of the toolkit.
  • *_benchmark, for ROS packages. These are misnomers. These packages are not benchmarks but collections of benchmarks.

So I propose some renaming:

  • lambkin (the package) --> lambkin-shepherd (using namespace packages)
  • slam_toolbox_benchmark --> slam_toolbox_benchmarks
  • cartographer_ros_benchmark --> cartographer_ros_benchmarks
@hidmic hidmic added meta needs-work Ready to be worked on labels May 5, 2023
@hidmic hidmic mentioned this issue May 5, 2023
6 tasks
@hidmic hidmic closed this as completed in #46 May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta needs-work Ready to be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant