You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using Sphinx for PDF report generation (#20), we need to rely on ImageConverters to convert images that are not supported by the builder (pdflatex only supports PDF, PNG and JPEG image formats).
The current implementation of ImageConverter only uses the image basename to store the converted image in the images directory. This means that if we have an image with the same name in different subdirectories, the converted images will overwrite each other. See this handle function and this utility function using the basename of the source path.
Definition of Done
Add support for SVG, PGM and other image formats to lambkin report generation process.
Additional considerations
Possible solutions:
We can have the user specify a given output image format to lambkin during benchmark configuration, so we generate the formats supported by the builder.
We could flatten the image paths before generating the report and use ImageConverters.
We could submit a patch upstream and hope for the best.
The text was updated successfully, but these errors were encountered:
We could submit a patch upstream and hope for the best.
This one would be best, but yeah, I fear Sphinx release cadence.
We can have the user specify a given output image format to lambkin during benchmark configuration, so we generate the formats supported by the builder.
Now that I think of it, we should probably always generate PNGs. AFAIK it's the PDF of image formats.
Description
When using Sphinx for PDF report generation (#20), we need to rely on ImageConverters to convert images that are not supported by the builder (
pdflatex
only supports PDF, PNG and JPEG image formats).The current implementation of
ImageConverter
only uses the image basename to store the converted image in theimages
directory. This means that if we have an image with the same name in different subdirectories, the converted images will overwrite each other. See this handle function and this utility function using the basename of the source path.Definition of Done
lambkin
report generation process.Additional considerations
Possible solutions:
lambkin
during benchmark configuration, so we generate the formats supported by the builder.ImageConverters
.The text was updated successfully, but these errors were encountered: