-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user guide on how to extend Beluga #450
Conversation
Signed-off-by: Michel Hidalgo <[email protected]>
As per #306, it looks like I'm missing a custom sampling view. I'll add that next. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hidmic Looks great!
I think I'm going to hold this off until we have more resampling algorithms. We only define a naive multinomial sampler. There's #48, there's stratified resampling, there's residual resampling, and more. I presume we'll be using views all the way, but some algorithms have to perform multiple passes and carry additional state so the standard resampling algorithm structure may end being a tiny bit more complicated than |
Signed-off-by: Michel Hidalgo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed changes
Closes #306 . This patch adds a guide on how to extend Beluga. I covered the fraction of the library that is the most stable regarding patterns and architecture and also the most likely one for a user to extend -- new kinds of particles filters or support abstractions I skipped.
Type of change
Checklist
Put an
x
in the boxes that apply. This is simply a reminder of what we will require before merging your code.