Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updated performance report #254

Closed
wants to merge 1 commit into from

Conversation

glpuga
Copy link
Collaborator

@glpuga glpuga commented Sep 3, 2023

Proposed changes

This PR adds a new performance report, since the latest one predates important performance enhancing changes in the code.

This PR also identified #253 and had to circumvent it to make the actual capture of metrics.

This results need to be independently replicated before merging. The results are out of line with the latest results for a similar code version, and I've don't have a full explanation for the differences (see #233 )

beam_beluga_vs_beluga_vs_amcl

likelihood_beluga_vs_beluga_vs_amcl

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@glpuga glpuga self-assigned this Sep 3, 2023
@glpuga glpuga force-pushed the glpuga/update_performance_report branch from 9174505 to 39f027e Compare September 3, 2023 16:09
@glpuga glpuga marked this pull request as ready for review September 3, 2023 16:10
@glpuga
Copy link
Collaborator Author

glpuga commented Sep 3, 2023

@hidmic @nahueespinosa since these results are so much different from the latest ones we got, and I can't really explain all the differences, this needs to be thoroughly reviewed and replicated before merging.

@glpuga glpuga marked this pull request as draft September 3, 2023 16:27
@glpuga
Copy link
Collaborator Author

glpuga commented Sep 3, 2023

Forget about it.

The launch files are broken, all the measurements were using the same configuration, that why beam model looks to good, and yet so similar to likelihood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant