-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release v3.8 #517
release v3.8 #517
Conversation
Feedback V3.8 Egyras Build138 Signature "550efd7" When testing 3.8 I saw the following in the debug log file: It starts with the FW update. I use the new CoPilot Rule Version4. After restarting, the variables #Delta and #TOP27Backup are set to NULL. These 2 variables are first supplied with values from Jeisha in Timer11. Therefore, I only call Timer11 after 10 seconds from the “System#Boot” so that there is time for the first synchronization with the HP. The log file shows that Timer11 should be executed in 10 seconds from System#Boot (line 317). Since timer 11 is called immediately afterwards and the Jeisha data is not yet available by then, this error occurs. I can see from the timestamp that the 10 seconds are ignored. It is also strange in line 328 that the value of #Delta is displayed correctly with the initial assignment from System#Boot. The next time it is displayed on line 354, a space is missing and the value is NULL. Rules code excerpt from Timer 11:
|
This reverts commit 68af658.
Wait before release v3.8. You reverted the v3.7 fix from yesterday but that fix was ok :) |
@Egyras this build is now good... please make this a release v3.8 @McMagellan nothing got changed for the rules part between your tested version v3.7 and this one so I can't say what is going on but I understand it is not a big thing |
For me it is clear what happened. Line 316 -> System#Boot This also means that the grayed out calculations in the rule of Timer 11 are all carried out incorrectly because there is no "True" in relation to a variable that is not supplied. I've noticed for a long time that the first timer from System#Boot is called too briefly. It's not a current problem. After I log the debug port with Putty, I can now document it in a comprehensible way. The special situation immediately after a firmware upload can also play a role. |
Ok something for @CurlyMoo to look at. Not a breaker for v3.8 |
The behavior already exists in V3.2. Now I can document it. |
The timer is actual time independent. The only thing it does it do a count down. When a timer reaches a count down of zero it fires. The only thing that i can think of going wrong is that the timers are not fully cleared when parsing. So it fires after parsing the |
So can you check if it fires 10 seconds after the |
This fixes an issue in v3.7 while saving settings.
v3.8 will include the v3.7 changes: