-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fapar-lai dataset #40
Conversation
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! It works well.
There is one small concern. In the test, we save a sample file in the download folder and an unzipped copy of the file. Since the file is slightly large (~15MB), it would be nice to unzip the zip file on the fly when running the test for load function. We can optimize it later in another PR.
ds = lai_dataset.load( | ||
ingest_dir=data_folder / "fapar-lai" / "ingest", | ||
time_bounds=times, | ||
spatial_bounds=bbox, | ||
variable_names=variable, | ||
resolution=1.0, | ||
regrid_method="flox", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A copy of unzipped data is kept for this test. We can reuse the zip file in the download folder and unzip it on the fly. This way we can avoid these three nc files which adds up to 15MB in total.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An issue is created for it #44.
Thanks for the review Yang! 😄 |
test recipe:
TODO: