-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To review this PR, just check the tests. Note that since functions using xesmf
relying on conda/mamba environment, therefore tests related to those functions are conditional (but they are tested under the mamba
CD/CI action).
Note that CD/CI on windows fails due to an unexpected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geek-yang nice work on adding tests 👍 The tests cover most of the codes, well done. 🚀 Thank you for setting up the sonarcloud, too. I left some comments, please let me know if something is unclear. Besides those comments, I am wondering if we can re-organize files e.g. now there is a utils.py
file and there is a directory utils
. This is confusing. Can utils.py
be moved to utils
folder?
Co-authored-by: SarahAlidoost <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Thanks a lot for your review @SarahAlidoost. The comments help a lot. I think I have addressed all of them, please take a look again. Regarding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geek-yang thank you for addressing the comments 👍
We add tests to
zampy.datasets
functions and functions inutils
.