Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Bart Schilperoort <[email protected]>
  • Loading branch information
geek-yang and BSchilperoort authored Nov 15, 2023
1 parent 5a890ad commit 0028595
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions src/zampy/datasets/land_cover.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,13 +164,9 @@ def convert(
data_files = list(ingest_folder.glob(data_file_pattern))

for file in data_files:
# start conversion process
print(f"Start processing file `{file.name}`.")
ds = xr.open_dataset(file)
ds = converter.convert(ds, dataset=self, convention=convention)
# TODO: support derived variables
# TODO: other calculations
# call ds.compute()

return True

Expand Down Expand Up @@ -231,8 +227,8 @@ def extract_netcdf_to_zampy(file: Path) -> xr.Dataset:
east=180,
south=-90,
west=-180,
resolution_lat=0.25, # same as resolution of ERA5
resolution_lon=0.25,
resolution_lat=0.05,
resolution_lon=0.05,
)

target_dataset = xarray_regrid.create_regridding_dataset(new_grid)
Expand Down

0 comments on commit 0028595

Please sign in to comment.