-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement groundwater coupling changes in BMI #101
Conversation
All new variables for the groundwater coupling have been implemented. Should work in theory, but still needs to be double checked with a new docker image. In a subsequent PR, the variables in this table can be added. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BSchilperoort thanks 👍 I was able to run the notebook for a few time steps with the new exe file in EcoExtreML/STEMMUS_SCOPE#239. Just some minor comments and the linter errors below.
I've incorporated your comments @SarahAlidoost . Once the 1.6.0 stemmus_scope image is on the container registry, this PR can be finished up. |
Quality Gate passedIssues Measures |
Testable with the executable file from the main branch of STEMMUS_SCOPE.
I also reworked the bmi variable definitions to reduce duplication. It now uses a dataclass BmiVariable.