Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement groundwater coupling changes in BMI #101

Merged
merged 12 commits into from
Aug 30, 2024

Conversation

BSchilperoort
Copy link
Contributor

Testable with the executable file from the main branch of STEMMUS_SCOPE.

I also reworked the bmi variable definitions to reduce duplication. It now uses a dataclass BmiVariable.

@BSchilperoort
Copy link
Contributor Author

All new variables for the groundwater coupling have been implemented. Should work in theory, but still needs to be double checked with a new docker image.

In a subsequent PR, the variables in this table can be added.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

sonarcloud bot commented Jul 15, 2024

@BSchilperoort BSchilperoort marked this pull request as ready for review July 15, 2024 12:22
Copy link
Member

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BSchilperoort thanks 👍 I was able to run the notebook for a few time steps with the new exe file in EcoExtreML/STEMMUS_SCOPE#239. Just some minor comments and the linter errors below.

@BSchilperoort
Copy link
Contributor Author

I've incorporated your comments @SarahAlidoost . Once the 1.6.0 stemmus_scope image is on the container registry, this PR can be finished up.

Copy link

sonarcloud bot commented Aug 30, 2024

@BSchilperoort BSchilperoort merged commit d2e9186 into main Aug 30, 2024
16 checks passed
@BSchilperoort BSchilperoort deleted the bmi-groundwater-coupling branch August 30, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants