Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revise IS, relates to (#252) #260

Merged
merged 3 commits into from
Sep 25, 2024
Merged

revise IS, relates to (#252) #260

merged 3 commits into from
Sep 25, 2024

Conversation

Crystal-szj
Copy link
Contributor

@Crystal-szj Crystal-szj commented Sep 25, 2024 •
edited
Loading

Description

relates #252
Refactoring changes the values of soil properties. This pull request is to revise this problem. A detailed description can be found at #252

Checklist

  • Add a reference to related issues.
  • @mentions of the person or team responsible for reviewing proposed changes.
  • This pull request has a descriptive title.
  • Code is written according to the guidelines.
  • The checks by MISS_HIT style checker and linter, below the pull request, are successful (green).
  • Documentation is available.
  • Add changes to the changelog file under section Unreleased.
  • Model runs successfully.
  • Ask a meinatainer to re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

@Crystal-szj Crystal-szj mentioned this pull request Sep 25, 2024
Open
SarahAlidoost
SarahAlidoost approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Crystal-szj thanks for the fixes 👍

@SarahAlidoost SarahAlidoost merged commit 56f2c81 into main Sep 25, 2024
1 check passed
@Crystal-szj Crystal-szj deleted the revise-IS branch September 25, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SarahAlidoost SarahAlidoost SarahAlidoost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Crystal-szj @SarahAlidoost