Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix soil temperature issues #245

Merged
merged 16 commits into from
Aug 14, 2024
Merged

Fix soil temperature issues #245

merged 16 commits into from
Aug 14, 2024

Conversation

MostafaGomaa93
Copy link
Contributor

@MostafaGomaa93 MostafaGomaa93 commented Jul 30, 2024 •
edited by SarahAlidoost
Loading

Description

relates #242

Checklist

  • Add a reference to related issues.
  • @mentions of the person or team responsible for reviewing proposed changes.
  • This pull request has a descriptive title.
  • Code is written according to the guidelines.
  • The checks by MISS_HIT style checker and linter, below the pull request, are successful (green).
  • Documentation is available.
  • Add changes to the changelog file under section Unreleased.
  • Model runs successfully.
  • Ask a meinatainer to re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

@MostafaGomaa93 MostafaGomaa93 mentioned this pull request Jul 30, 2024
Open
SarahAlidoost
SarahAlidoost reviewed Aug 1, 2024
View reviewed changes
src/STEMMUS_SCOPE.m Outdated Show resolved Hide resolved
SarahAlidoost
SarahAlidoost reviewed Aug 13, 2024
View reviewed changes
src/STEMMUS_SCOPE.m Outdated Show resolved Hide resolved
SarahAlidoost
SarahAlidoost approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MostafaGomaa93 thanks for fixing the code

@SarahAlidoost SarahAlidoost merged commit d4ddc41 into main Aug 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SarahAlidoost SarahAlidoost SarahAlidoost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MostafaGomaa93 @SarahAlidoost