Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust to let total soil thickness and max root depth be varied and not fixed #238

Merged
merged 7 commits into from
Jul 5, 2024

Conversation

MostafaGomaa93
Copy link
Contributor

@MostafaGomaa93 MostafaGomaa93 commented Jul 3, 2024

Description

The indices of the first 4 layers (layers close to land surface) are from 51 to 55 (as long as the total soil thickness equals 5 m). However, if we change the total soil thickness (not 5 m), then the indices of the first 4 layers will not be from 51 to 55 anymore. So, a simple change in these 3 files (one, two, three) to get the proper indices of the first 4 layers. These changes are related to issue 237.

Checklist

  • Add a reference to related issues.
  • @mentions of the person or team responsible for reviewing proposed changes.
  • This pull request has a descriptive title.
  • Code is written according to the guidelines.
  • The checks by MISS_HIT style checker and linter, below the pull request, are successful (green).
  • Documentation is available.
  • Add changes to the changelog file under section Unreleased.
  • Model runs successfully.
  • Ask a meinatainer to re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

@MostafaGomaa93 MostafaGomaa93 requested review from Yunfei-Wang1993 and SarahAlidoost and removed request for Yunfei-Wang1993 July 4, 2024 09:59
Copy link
Member

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MostafaGomaa93 please see my comment on the size of ModelSettings.DeltZ. Also, can you add one line to the changelog file explaining the changes? Thanks. After fixing the code, I will re-generate the exe file.

@MostafaGomaa93
Copy link
Contributor Author

@MostafaGomaa93 please see my comment on the size of ModelSettings.DeltZ. Also, can you add one line to the changelog file explaining the changes? Thanks. After fixing the code, I will re-generate the exe file.

Could you show me how can I make changes in the changelog file and where is that file?

@SarahAlidoost
Copy link
Member

@MostafaGomaa93 please see my comment on the size of ModelSettings.DeltZ. Also, can you add one line to the changelog file explaining the changes? Thanks. After fixing the code, I will re-generate the exe file.

Could you show me how can I make changes in the changelog file and where is that file?

The CHANGELOG.md is in the root of STEMMUS_SCOPE folder. In the file, under the section Unreleased/fixed, you can add one item for explaining changes in this pull request. Here example:

# Unreleased

**Changed:**

- ....

**Fixed:**

- .....
- The issue of defining te indices of first four layers.... is fixed in .... 

@MostafaGomaa93
Copy link
Contributor Author

@MostafaGomaa93 please see my comment on the size of ModelSettings.DeltZ. Also, can you add one line to the changelog file explaining the changes? Thanks. After fixing the code, I will re-generate the exe file.

Could you show me how can I make changes in the changelog file and where is that file?

The CHANGELOG.md is in the root of STEMMUS_SCOPE folder. In the file, under the section Unreleased/fixed, you can add one item for explaining changes in this pull request. Here example:

# Unreleased

**Changed:**

- ....

**Fixed:**

- .....
- The issue of defining te indices of first four layers.... is fixed in .... 

Thanks, I did it already

Copy link
Member

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MostafaGomaa93 thanks for the fixes 👍

@SarahAlidoost SarahAlidoost merged commit 8ac3e4d into main Jul 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants