-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust to let total soil thickness and max root depth be varied and not fixed #238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MostafaGomaa93 please see my comment on the size of ModelSettings.DeltZ. Also, can you add one line to the changelog file explaining the changes? Thanks. After fixing the code, I will re-generate the exe file.
Could you show me how can I make changes in the changelog file and where is that file? |
The CHANGELOG.md is in the root of # Unreleased
**Changed:**
- ....
**Fixed:**
- .....
- The issue of defining te indices of first four layers.... is fixed in .... |
Thanks, I did it already |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MostafaGomaa93 thanks for the fixes 👍
Description
The indices of the first 4 layers (layers close to land surface) are from 51 to 55 (as long as the total soil thickness equals 5 m). However, if we change the total soil thickness (not 5 m), then the indices of the first 4 layers will not be from 51 to 55 anymore. So, a simple change in these 3 files (one, two, three) to get the proper indices of the first 4 layers. These changes are related to issue 237.
Checklist
Unreleased
.