-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explanation of Soil_Inertia1.m #224
base: main
Are you sure you want to change the base?
Conversation
@EntingTang Good job 👍. The explanation makes the code more readable. |
In addtion to the added explanations, I found three points for potential improvements (reference: Inertial1_Murray and Verhoef (2007).pdf):
However, the parameter
Please correct me if there are any misunderstandings or omissions in my interpretation. If the above-mentioned points are valid, shall I open an issue to address them? @SarahAlidoost @yijianzeng @Yunfei-Wang1993 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EntingTang, I added the explanation of input and output variables and the complete information on your cited paper. Please help to check.
@@ -1,34 +1,34 @@ | |||
function [GAM] = Soil_Inertia1(SMC, theta_s0) | |||
% soil inertia method by Murray and Verhoef ( | |||
% soil inertia method by Murray and Verhoef (2007), and the soil inertial (GAM) is used to calculate the soil heat flux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
% soil inertia method by Murray and Verhoef (2007), and the soil inertial (GAM) is used to calculate the soil heat flux | |
% soil inertia method by Murray and Verhoef (2007), and the soil inertial (GAM) is used to calculate the soil heat flux | |
% Input: | |
% SMC : soil moisture (m3 m-3) | |
% theta_s0 : saturated soil moisture (m3 m-3) | |
% Output: | |
% GAM : soil inertia (J m-2 K-1 s-0.5) | |
% Reference: | |
% Murray, T., Verhoef, A., 2007. Moving towards a more mechanistic approach in the determination of soil heat | |
% flux from remote measurements: I. A universal approach to calculate thermal inertia. Agricultural and Forest | |
% Meteorology 147, 80-87. |
@EntingTang and @Crystal-szj Hi, are you still working on this pull request? can the changes be finalized and merged? |
Description
Add reference and explanation of Soil_Inertia1.m
Checklist
Unreleased
.