Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanation of Soil_Inertia1.m #224

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

EntingTang
Copy link

@EntingTang EntingTang commented Mar 14, 2024

Description

Add reference and explanation of Soil_Inertia1.m

Checklist

  • Add a reference to related issues.
  • @mentions of the person or team responsible for reviewing proposed changes.
  • This pull request has a descriptive title.
  • Code is written according to the guidelines.
  • The checks by MISS_HIT style checker and linter, below the pull request, are successful (green).
  • Documentation is available.
  • Add changes to the changelog file under section Unreleased.
  • Model runs successfully.
  • Ask a meinatainer to re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

@Crystal-szj
Copy link
Contributor

@EntingTang Good job 👍. The explanation makes the code more readable.

@EntingTang EntingTang requested review from bobzsu and removed request for bobzsu March 14, 2024 20:23
@EntingTang
Copy link
Author

EntingTang commented Mar 14, 2024

In addtion to the added explanations, I found three points for potential improvements (reference: Inertial1_Murray and Verhoef (2007).pdf):

  1. "QC" (quartz content) is a user-defined parameter that varies based on soil type (see Table 1 in the reference). If data for QC are not available, QC can be assumed equal to "fss" (sand fraction).
  2. "gamma_s" is dependent on "fss" (sand fraction): if fss>0.4, gamma_s=0.96 while fss≤0.4, gamma_s=0.27.

However, the parameter fss is currently not utilized in the code. If we have this data from the global dataset, it would be better to use the fss here and might improve the accuracy of calculation on GAM.

  1. A bug at Line 21: lambda_s = (lambda_qc^(QC)) * lambda_d^(1 - QC);, where the "lambda_d" should actually be "lambda_o" (see Eq.(18) in the reference). lambda_o represents the thermal conductivity of other minerals. The value of lambda_o is determined by QC: If QC>0.2, lambda_o=2.0 W m-1 K-1; otherwise lambda_o=3.0 W m-1 K-1.

Please correct me if there are any misunderstandings or omissions in my interpretation. If the above-mentioned points are valid, shall I open an issue to address them? @SarahAlidoost @yijianzeng @Yunfei-Wang1993

Copy link
Contributor

@Crystal-szj Crystal-szj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EntingTang, I added the explanation of input and output variables and the complete information on your cited paper. Please help to check.

@@ -1,34 +1,34 @@
function [GAM] = Soil_Inertia1(SMC, theta_s0)
% soil inertia method by Murray and Verhoef (
% soil inertia method by Murray and Verhoef (2007), and the soil inertial (GAM) is used to calculate the soil heat flux
Copy link
Contributor

@Crystal-szj Crystal-szj Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
% soil inertia method by Murray and Verhoef (2007), and the soil inertial (GAM) is used to calculate the soil heat flux
% soil inertia method by Murray and Verhoef (2007), and the soil inertial (GAM) is used to calculate the soil heat flux
% Input:
% SMC : soil moisture (m3 m-3)
% theta_s0 : saturated soil moisture (m3 m-3)
% Output:
% GAM : soil inertia (J m-2 K-1 s-0.5)
% Reference:
% Murray, T., Verhoef, A., 2007. Moving towards a more mechanistic approach in the determination of soil heat
% flux from remote measurements: I. A universal approach to calculate thermal inertia. Agricultural and Forest
% Meteorology 147, 80-87.

@SarahAlidoost
Copy link
Member

@EntingTang and @Crystal-szj Hi, are you still working on this pull request? can the changes be finalized and merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants