-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make STEMMUS_SCOPE BMI-able #208
Conversation
@SarahAlidoost first local test of running the model's initialization, update and finalize steps separately seems to be successful! Thanks for the hard work of cleaning up the code and removing all globals 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BSchilperoort nice work, thank you. I was able to run the model using the source code. In general, the BMI implementation is awesome. Just some minor comments, meantime, I am going to test the exe file with a new version of rutime 😄
I've adressed all your comments @SarahAlidoost, and made some other changes I wanted to make. You can now start the BMI mode without passing in a valid config:
The config is then passed with initialize:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BSchilperoort thanks, please see my comments on new changes and one old comment here.
this command is not correct. It returns error: Error using STEMMUS_SCOPE_exe
Too many input arguments.
MATLAB:TooManyInputs |
Co-authored-by: SarahAlidoost <[email protected]>
Co-authored-by: SarahAlidoost <[email protected]>
Thanks for the review! I have committed your suggestions and addressed your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BSchilperoort awesome 👍 thanks for fixing the issues, feel free to merge 🚀
Description
This PR will make STEMMUS_SCOPE compatible with a full BMI implemented in Python.
The documentation on this is still to-do (once PyStemmusScope has the BMI implemented EcoExtreML/STEMMUS_SCOPE_Processing#89)
Checklist
Unreleased
.