Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 99 #194

Merged
merged 13 commits into from
Oct 3, 2023
Merged

Fix issue 99 #194

merged 13 commits into from
Oct 3, 2023

Conversation

SarahAlidoost
Copy link
Member

@SarahAlidoost SarahAlidoost commented Sep 12, 2023

Description

closes #99

Checklist

  • Add a reference to related issues.
  • @mentions of the person or team responsible for reviewing proposed changes.
  • This pull request has a descriptive title.
  • Code is written according to the guidelines.
  • The checks by MISS_HIT style checker and linter, below the pull request, are successful (green).
  • Documentation is available.
  • Add changes to the changelog file under section Unreleased.
  • Model runs successfully.
  • Ask a meinatainer to re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

This PR generates the same results as the main branch. Note that dryair.solveDryAirEquations runs only if Soilairefc == 1. However, the current value of Soilairefc is 0, see getModelSettings.m. Therefore, this part of the code hasn't been tested before, see #196. I fixed the bugs and now when Soilairefc==1 model runs and the refactored parts generate the same results as the old codes.

@SarahAlidoost SarahAlidoost marked this pull request as ready for review October 2, 2023 08:17
Copy link
Contributor

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! No comments from me 😄

Did you run the branch-comparison notebook already for these changes? Or should I do that.

src/STEMMUS_SCOPE.m Show resolved Hide resolved
@SarahAlidoost
Copy link
Member Author

Looks very good! No comments from me 😄

Did you run the branch-comparison notebook already for these changes? Or should I do that.

Thanks, yes I did it.

@SarahAlidoost SarahAlidoost merged commit 938cc96 into main Oct 3, 2023
1 check passed
@SarahAlidoost SarahAlidoost deleted the fix_issue_99 branch October 3, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Air_sub, move all Air_ functions
2 participants