Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 163 coding style #190

Merged
merged 2 commits into from
Jul 18, 2023
Merged

fix issue 163 coding style #190

merged 2 commits into from
Jul 18, 2023

Conversation

Crystal-szj
Copy link
Contributor

@Crystal-szj Crystal-szj commented Jul 17, 2023

Description

Revising coding style according to MISS_HIT checks

Checklist

  • Add a reference to related issues.
  • @mentions of the person or team responsible for reviewing proposed changes.
  • This pull request has a descriptive title.
  • Code is written according to the guidelines.
  • The checks by MISS_HIT style checker and linter, below the pull request, are successful (green).
  • Documentation is available.
  • Add changes to the changelog file under section Unreleased.
  • Model runs successfully.
  • Ask a meinatainer to re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

@Crystal-szj
Copy link
Contributor Author

Hi @SarahAlidoost, thanks very much for your review and comments on issue #174. I managed to make all checks pass the MISS_HIT checker. Now all the style checkers are green. Could I merge this branch to the main branch directly?

@SarahAlidoost
Copy link
Member

Hi @SarahAlidoost, thanks very much for your review and comments on issue #174. I managed to make all checks pass the MISS_HIT checker. Now all the style checkers are green. Could I merge this branch to the main branch directly?

Good work! Thanks for fixing the linter errors. Yes please merge it 👍

@Crystal-szj Crystal-szj merged commit 0e0af05 into main Jul 18, 2023
@Crystal-szj Crystal-szj deleted the fix_163_codingStyle branch July 18, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants