feat: added --solana-key flag to derive destination address #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description ----------- - introduced --solana-key flag - added support for reading Solana keypair files and deriving public keys - implemented validation to prevent using both --solana-key and --destination - added test suite for the introduced feat - improved error handling for invalid key files Usage ----- Clone this PR branch and install dependencies and make sure you followed the readme to derive eth key `private-key.txt` and solana key `key.json` and then run ``` node bin/cli.js -k private-key.txt --solana-key key.json -a 0.002 --sepolia ``` Testing the introduced feat --------------------------- From the root direcoty, run: ``` yarn test ``` chore: format
0xObsidian
force-pushed
the
0xObsidian/solana-key-flag-to-derive-destination-addr
branch
from
dd6f591 to
ecaf738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--solana-keyflag--solana-keyand--destinationUsage
Clone this PR branch and install dependencies and make sure you followed the readme to derive eth key
private-key.txtand solana keykey.jsonand then runTesting the introduced feat
From the root direcoty, run:
yarn testThis PR addresses ticket #36