Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move an AWS course from books to courses section #6987

Conversation

AhmedElTabarani
Copy link
Contributor

@AhmedElTabarani AhmedElTabarani commented Aug 5, 2022

What does this PR do?

Fix the mistake of #6752 PR

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@davorpa davorpa changed the title Remove an AWS course from books to courses section Move an AWS course from books to courses section Aug 5, 2022
@davorpa davorpa added the 🗣️ locale:ar Resources addressing "Arabic / العربية" language label Aug 5, 2022
@davorpa davorpa added the 🚀 ready to merge LGTM. Waiting for final approval label Aug 5, 2022
@davorpa
Copy link
Member

davorpa commented Aug 5, 2022

Right addressed PR is #6752

@AhmedElTabarani
Copy link
Contributor Author

AhmedElTabarani commented Aug 7, 2022

@davorpa is there a way to make multiple PR ? if I do 2 PR in difference branch, the second one will hold the previous commit of the first PR (which is in difference branch)

I must be waiting for the first one to been merged to make the branch based on the upstream repo.

@davorpa
Copy link
Member

davorpa commented Aug 7, 2022

@davorpa is there a way to make multiple PR ? if I do 2 PR in difference branch, the second one will hold the previous commit of the first PR (which is in difference branch)

I must be waiting for the first one to been merged to make the branch based on the upstream repo.

Is discouraged to use incremental PRs sharing same branch (at least here, that we use squash as merge strategy).

Is more an idiomatic and organizative problem than ones of we can do. If you think that two commits should be in the same branch, maybe needs rename PR to grow it scope in the middle of both pushes

@AhmedElTabarani
Copy link
Contributor Author

AhmedElTabarani commented Aug 7, 2022

Is discouraged to use incremental PRs sharing same branch (at least here, that we use squash as merge strategy).

Is more an idiomatic and organizative problem than ones of we can do. If you think that two commits should be in the same branch, maybe needs rename PR to grow it scope in the middle of both pushes

I always making a new branch for new changes, but the new branch take the commits of the old branch (different branch names), i think i will figure out the solution

But can you tell me a advice to avoid that the new branch takes the commits of old branch ?

@davorpa
Copy link
Member

davorpa commented Aug 7, 2022

But can you tell me a advice to avoid that the new branch takes the commits of old branch ?

Easy! Is posible make a branch from any commit. Navigate from your repo timeline using any editor like VSCode or from web

image
image
image
image

@eshellman eshellman merged commit 45c1e5b into EbookFoundation:main Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 ready to merge LGTM. Waiting for final approval 🗣️ locale:ar Resources addressing "Arabic / العربية" language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants