Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update free-courses-bn.md #6891

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Update free-courses-bn.md #6891

merged 2 commits into from
Jun 30, 2022

Conversation

jonyahmed19
Copy link
Contributor

@jonyahmed19 jonyahmed19 commented Jun 30, 2022 •
edited
Loading

Added Mern stack bangla playlist

What does this PR do?

Add resource(s) | Remove resource(s) | Add info | Improve repo

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@jonyahmed19
Update free-courses-bn.md
e4478d5 
Added Mern stack bangla playlist
@eshellman
Copy link
Collaborator

For youtube, we prefer "playlist" links and the name of the producer/creator. https://github.com/EbookFoundation/free-programming-books/blob/master/CONTRIBUTING.md#platforms-and-access-notes
It seems the linter is not enforcing alphabetical order in Bangla?

davorpa
davorpa requested changes Jun 30, 2022
View reviewed changes
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good moment to apply some changes. When done, request for a review again using GitHub 🔃 button. Meanwhile, draft status can be used to work on it if you want.

courses/free-courses-bn.md Outdated
Comment on lines 125 to 126
* [Full MERN Stack Course](https://www.youtube.com/watch?v=ewBBT6Iph0M&list=PL_XxuZqN0xVD0op-QDEgyXFA4fRPChvkl) - Stack Learner
* [Dive Into NodeJS](https://www.youtube.com/playlist?list=PL_XxuZqN0xVDHFj-ecFSU0SU-B0TuJRk9) - Stack Learner
Copy link
Member

@davorpa davorpa Jun 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetize, update resource title and use playlist url as Eric says

Suggested change
* [Full MERN Stack Course](https://www.youtube.com/watch?v=ewBBT6Iph0M&list=PL_XxuZqN0xVD0op-QDEgyXFA4fRPChvkl) - Stack Learner
* [Dive Into NodeJS](https://www.youtube.com/playlist?list=PL_XxuZqN0xVDHFj-ecFSU0SU-B0TuJRk9) - Stack Learner
* [Dive Into NodeJS](https://www.youtube.com/playlist?list=PL_XxuZqN0xVDHFj-ecFSU0SU-B0TuJRk9) - Stack Learner
* [Full-stack Army - Complete MERN Stack Journey in Bangla](https://www.youtube.com/playlist?list=PL_XxuZqN0xVD0op-QDEgyXFA4fRPChvkl) - Stack Learner

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Let me modify

@davorpa davorpa added question Needs clarification by involved users / reviewers waiting for changes PR has been reviewed and changes/suggestions requested 🗣️ locale:bn Resources addressing "Bengali / বাংলা" language labels Jun 30, 2022
@davorpa
Copy link
Member

davorpa commented Jun 30, 2022 •
edited
Loading

For youtube, we prefer "playlist" links and the name of the producer/creator. https://github.com/EbookFoundation/free-programming-books/blob/master/CONTRIBUTING.md#platforms-and-access-notes It seems the linter is not enforcing alphabetical order in Bangla?

It seems 😟.

English should be used if some language is not registered in linter.

But Bangla is one of these languages added at Hacktoberfest 2021 pending to support by linter (see backlog #5762)

@davorpa davorpa removed the question Needs clarification by involved users / reviewers label Jun 30, 2022
jonyahmed19
jonyahmed19 commented Jun 30, 2022
View reviewed changes
Copy link
Contributor Author

@jonyahmed19 jonyahmed19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed to alphabetical order

@eshellman
Copy link
Collaborator

Thanks, and welcome to free-programming-books!

@eshellman eshellman merged commit c257de2 into EbookFoundation:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davorpa davorpa davorpa requested changes

Assignees

@jonyahmed19 jonyahmed19

Labels
🗣️ locale:bn Resources addressing "Bengali / বাংলা" language waiting for changes PR has been reviewed and changes/suggestions requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonyahmed19 @eshellman @davorpa