Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Normalize Learn With Sumit attribution #6787

Conversation

davorpa
Copy link
Member

@davorpa davorpa commented Mar 18, 2022

What does this PR do?

Improve repo

For resources

Description

Why is this valuable (or not)?

Adds instructor name of Learn With Sumit playlists and transfer current text as platform field.

Also removes timestamp parameter on youtube videos

So... finally resolves #5271, #6435, #6626 via backlog task listed at #5762

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@davorpa davorpa added the 🗣️ locale:bn Resources addressing "Bengali / বাংলা" language label Mar 18, 2022
@davorpa davorpa self-assigned this Mar 18, 2022
@davorpa davorpa marked this pull request as ready for review March 18, 2022 18:53
@davorpa davorpa mentioned this pull request Mar 18, 2022
39 tasks
@LuigiImVector LuigiImVector added the 🚀 ready to merge LGTM. Waiting for final approval label Mar 19, 2022
@eshellman eshellman merged commit 220a421 into EbookFoundation:main Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 ready to merge LGTM. Waiting for final approval 🗣️ locale:bn Resources addressing "Bengali / বাংলা" language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants