Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(free-programming-books-subjects): fixed broken links #5470 #6471

Merged
merged 12 commits into from
Nov 11, 2021

Conversation

LuigiImVector
Copy link
Member

What does this PR do?

Add info | Improve repo

For resources

Description

I fixed the broken links on free-programming-books-subjects.md, see #5470.

False-positive links: 07, 11, 12, 15

Checklist:

  • Read our contributing guidelines
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@eshellman
Copy link
Collaborator

Thanks!!! Would appreciate an additional set of eyes to check the non-pdf resources. Sometimes the wayback machine doesn't pick up deeply linked parts of a website. for archived github resources, check to see if there's a clone of the repo somewhere, a big fraction of github repos get cloned.

@eshellman eshellman added the help wanted Needs help solving a blocked / stucked item label Oct 27, 2021
@LuigiImVector
Copy link
Member Author

I checked the non-pdf links much more thoroughly and deleted the github repository (I didn't even find any clone) and schoolofdata.org since not all links are shown correctly, for example:

If you think that schoolofdata.org should be added again please tell me.

@davorpa davorpa added the question Needs clarification by involved users / reviewers label Oct 28, 2021
@@ -441,7 +441,7 @@ Books that cover a specific programming language can be found in the [BY PROGRA
* [Non-Uniform Random Variate Generation](http://luc.devroye.org/rnbookindex.html) - Luc Devroye (PDF)
* [Notes on Diffy Qs](https://www.jirka.org/diffyqs/) - Jiří Lebl
* [Number Theory](https://github.com/holdenlee/number-theory) - Holden Lee MIT
* [Number Theory: In Context and Interactive](http://math.gordon.edu/ntic/) - Karl-Dieter Crisman
* [Number Theory: In Context and Interactive](https://web.archive.org/web/20210711231452/https://math.gordon.edu/ntic/) - Karl-Dieter Crisman
Copy link
Member

@davorpa davorpa Oct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After #6471 (comment) , this is interesting....

image

Maybe we should wait for.

Moreover, wayback machine doesn't render well desplegable foo notes. At least there are PDF to download

I'm also thinking that the reason could be that website is an intranet...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we'll post it on #5470 and if it comes back online we'll change the link

Copy link
Member

@davorpa davorpa Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, remove for now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, remove for now

Archived link works fine for me. Frontmatter and PDF download continues available

Adding formats and notes

Suggested change
* [Number Theory: In Context and Interactive](https://web.archive.org/web/20210711231452/https://math.gordon.edu/ntic/) - Karl-Dieter Crisman
* [Number Theory: In Context and Interactive](https://web.archive.org/web/20210711231452/https://math.gordon.edu/ntic/) - Karl-Dieter Crisman (HTML, PDF) *(:card_file_box: archived)*

Copy link
Member

@davorpa davorpa Nov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, remove for now

Or remove...

Suggested change
* [Number Theory: In Context and Interactive](https://web.archive.org/web/20210711231452/https://math.gordon.edu/ntic/) - Karl-Dieter Crisman

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Available again https://math.gordon.edu/ntic/ 😉

@davorpa davorpa removed the help wanted Needs help solving a blocked / stucked item label Oct 29, 2021
@davorpa davorpa requested review from eshellman and removed request for eshellman November 9, 2021 16:52
@davorpa davorpa added waiting for changes PR has been reviewed and changes/suggestions requested and removed question Needs clarification by involved users / reviewers labels Nov 9, 2021
@eshellman eshellman merged commit 795e3ba into EbookFoundation:master Nov 11, 2021
@davorpa davorpa added the 🐛 BUG Confirmed bugs, normally at GitHub Pages label Feb 11, 2022
@davorpa davorpa added 🗣️ locale:en Resources addressing "English" language urlchecker Checker workflow monitoring the links of resources has found some warnings. See logs and fix URLs. labels Feb 22, 2022
@EbookFoundation EbookFoundation locked as resolved and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 BUG Confirmed bugs, normally at GitHub Pages 🗣️ locale:en Resources addressing "English" language urlchecker Checker workflow monitoring the links of resources has found some warnings. See logs and fix URLs. waiting for changes PR has been reviewed and changes/suggestions requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants