-
-
Notifications
You must be signed in to change notification settings - Fork 61.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CONTRIBUTING.md #5936
Merged
Merged
Update CONTRIBUTING.md #5936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made a spelling correction, for better understanding
davorpa
reviewed
Oct 5, 2021
Yes that's better.
…On Tue, Oct 5, 2021, 16:06 David Ordás ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In CONTRIBUTING.md
<#5936 (comment)>
:
> @@ -181,7 +181,7 @@ We're not that fussy about book-ness. Here are some attributes that signify that
- it has an ISBN (International Standard Book Number)
- it has a Table of Contents
-- a downloaded version, especially ePub, is offered
+- a downloadable version, especially ePub is preffered
Nice "download" catch but I think is better...
⬇️ Suggested change
-- a downloadable version, especially ePub is preffered
+- a downloadable version is offered, especially ePub files.
Are you agree?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#5936 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUWNZGTLDNQYSUSEUJAP2R3UFMPADANCNFSM5FLVPXAQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Then apply suggested patch Added to my backlog #5762 |
Co-authored-by: David Ordás <[email protected]>
davorpa
approved these changes
Oct 5, 2021
Thanks, and welcome to free-programming-books! |
Thank you for the opportunity to help.
…On Wed, Oct 6, 2021, 02:32 Eric Hellman ***@***.***> wrote:
Merged #5936
<#5936>
into master.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#5936 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUWNZGQD244DL5BS3T7CDCDUFOYMNANCNFSM5FLVPXAQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a spelling correction, for better understanding
What does this PR do?
Improved repo, by making corrections to the documentation.