Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding URL to CONTRIBUTING.md Indonesia version #5900

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

CakKhoiron
Copy link
Contributor

@CakKhoiron CakKhoiron commented Oct 4, 2021

Adding CONTRIBUTING Indonesia version in the English version

What does this PR do?

Add resource(s) | Remove resource(s) | Add info | Improve repo

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

Adding CONTRIBUTING Indonesia version in the English version
@davorpa
Copy link
Member

davorpa commented Oct 5, 2021

✍️ It's a good practice to fill Pull Request fields. It helps a bit we can understand your contribution better 🤗.

@davorpa davorpa self-assigned this Oct 5, 2021
@davorpa
Copy link
Member

davorpa commented Oct 5, 2021

This issue is assigned to me. repo documentation are too hot as to do more changes

Part of #5762

@davorpa davorpa added the 🚀 ready to merge LGTM. Waiting for final approval label Oct 5, 2021
@eshellman eshellman merged commit 764b926 into EbookFoundation:master Oct 5, 2021
@CakKhoiron
Copy link
Contributor Author

✍️ It's a good practice to fill Pull Request fields. It helps a bit we can understand your contribution better 🤗.

Duly noted.
Thank you for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 ready to merge LGTM. Waiting for final approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants