-
-
Notifications
You must be signed in to change notification settings - Fork 61.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(workflow): post build result as comment #5564
Conversation
Actually… GitHub just tried to run my new workflow in the PR for the new workflow? (Actually that makes sense, but RIP.) If GitHub will automatically run workflows for most users, and it will use the workflow configuration from their PR, that would open many opportunities to be malicious. I need to look into this. I'm currently reviewing the following documents, hopefully I'll have something better soon:
|
ece0dd8
to
e9f7dff
Compare
Current setting is to allow all actions and "Require approval for first-time contributors who are new to GitHub |
If this is not ready yet, we should at least remove Travis and associated documentation before October. |
This comment was marked as outdated.
This comment was marked as outdated.
… of files (#6696) * config: addopt current file formatting as yml & markdown parametrization Cherry picked from #5564: e9f7dff * add config properties for JSON files * extend config to all markdown file extensions * sort global properties * add mapping for python files * add windows batch files mapping * sort mapping entries * add makefile mapping properties * add file description / summary * add poweshell mappings * Comment each section * disable linebreaks on supported editors * Apply some suggestions * clean deadcode - simplify properties already defined in global section - remove not used future patterns
Whether this will be added is another thing, but regardless over at TLDR, there is a pretty printed message sent tldr-pages/tldr#7883 (comment) like that. Adding this helps new contributors easily fix their issues, so adding this would be a useful edition, especially with how many new Github users there are that contribute resources here and often make beginner mistakes. |
Accidentally hit the close and send button |
I'm thinking about coming back to this one later, but first I'd like vhf/free-programming-books-lint#29 to be resolved. 🤔 I think there was a discussion before about some of the linter repos being transferred to EbookFoundation, is that still a thing? |
Yes, you are right. Last word was about if somebody with minimal knowledges takes the control about npm registry account, it said Victor, to be able to make the deploys. In practice I think transfer |
GitHub made a new feature which might make this cleaner: It doesn't post a comment though, but rather than post a comment here we could use the summary feature and link to that page from here. |
@LuigiImVector do you see this to be applied to #6914. Use an envvar instead of write in temp file to compose lint report |
I didn't understand, do you mean to save the file name to an envvar? |
Sorry for no context. I forgot cite the last Seth's post:
Doing this I think isn't necesary a sub-workflow |
as soon as I have time I will try to implement it and check if it is okay, thanks |
More conflicts with #6696 and #6820 which contains parts with a more recent version (preserve both sides) |
e9f7dff
to
cd2245d
Compare
545b485
to
39a648b
Compare
39a648b
to
3f96f45
Compare
I'll close this in favor of #6914, where LuigiImVector has made substantially more progress toward this goal. |
What does this PR do?
Improve repo
Description
Why is this valuable (or not)?
I'm hoping this will make it easier for new contributors who don't understand how to check build failures, or can't find the warning in the logs.
Checklist:
Followup